Bug 37647 - Turn libatasmart, parted, lvm2 and device-mapper into optional dependencies
Summary: Turn libatasmart, parted, lvm2 and device-mapper into optional dependencies
Status: RESOLVED WORKSFORME
Alias: None
Product: udisks
Classification: Unclassified
Component: general (show other bugs)
Version: unspecified
Hardware: All All
: medium normal
Assignee: David Zeuthen (not reading bugmail)
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-05-26 14:24 UTC by Gustavo Sverzut Barbieri
Modified: 2012-09-28 16:01 UTC (History)
0 users

See Also:
i915 platform:
i915 features:


Attachments
first version to allow optional build with atasmart, lvm2, parted and device-mapper (16.50 KB, patch)
2011-05-26 14:24 UTC, Gustavo Sverzut Barbieri
Details | Splinter Review
second version to allow optional build with atasmart, lvm2, parted and device-mapper (15.88 KB, patch)
2011-05-28 07:30 UTC, Gustavo Sverzut Barbieri
Details | Splinter Review

Description Gustavo Sverzut Barbieri 2011-05-26 14:24:14 UTC
Created attachment 47200 [details] [review]
first version to allow optional build with atasmart, lvm2, parted and device-mapper

The attached patch enables udisks to be built without libatasmart, parted, lvm2 or device-mapper as not every system would like to have them (ie: my desktop or any mobile phone).

The patch should be quite simple and non-invasive by means of #ifdefs or not even compiling some helpers/probers altogether. The most controversial change would be the conversion of SkSmartOverall usage in headers from enum to guint, but I guess you can figure out from atasmart.h that it's not guaranteed to be fixed and that by itself would break with libatasmart changes (IOW it's now better).

Also note that many files included atasmart.h without actual need. These were removed instead of ifdef-ing the include.
Comment 1 Gustavo Sverzut Barbieri 2011-05-28 07:30:09 UTC
Created attachment 47254 [details] [review]
second version to allow optional build with atasmart, lvm2, parted and device-mapper

This one fixes the pkg-config name for libatasmart, I did a mistake and it was being called liblibatasmart in configure.ac
Comment 2 Gustavo Sverzut Barbieri 2011-07-21 09:56:26 UTC
Up? Could you please consider this bug?
Comment 3 David Zeuthen (not reading bugmail) 2012-09-28 16:01:16 UTC
Development focus is on udisks 2.0 now. In there, only libatasmart is a dependency and I'm not sure it's worth making that one optional.


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.