Damage presently ignores GC clipping information, causing damage to be overreported. A fix has been committed to kdrive: http://cvs.freedesktop.org/xserver/xserver/miext/damage/damage.c?r1=1.14&r2=1.15 To this report I'll attach a patch that fixes the same issue for xorg damage, taking out an earlier fix that partially fixed overreporting. The previous fix interesected against the window clip list according to the sub window mode. This is not needed for the new fix because pGC->pCompositeClip is the intersection between the window (depending on the sub window mode) and client clips already. One thing I don't understand about the previous fix is why it only clipped when there was no backing store ?
Created attachment 3089 [details] [review] Debug patch with fix
ah, backing store is evil. composite clip doesn't include the region preserved in backing store. we need to reimplement backing store in terms of composite and get rid of the existing horror show. so, we need to not clip damage at all when backing store is enabled, so the fix in xserver is incomplete.
Created attachment 3175 [details] [review] Proposed patch New patch does not clip if backing store is enabled.
Created attachment 3176 [details] [review] xls_locale_en_US This patch adds the backing store exception to xserver damage. If this looks good, I can get mallum to commit it again.
Created attachment 3178 [details] [review] fixes it Only cast to WindowPtr when actually dealing with a window.
Created attachment 3179 [details] The Bulgarian translation See last comment.
Previously attached patches lost in bugzilla disk death - links now point to other files. Please re-attach.
Created attachment 3523 [details] [review] Patch against xserver
Created attachment 3524 [details] [review] Patch against xc
Sorry about the phenomenal bug spam, guys. Adding xorg-team@ to the QA contact so bugs don't get lost in future.
(In reply to comment #2) > ah, backing store is evil. composite clip doesn't include the region preserved > in backing store. we need to reimplement backing store in terms of composite and > get rid of the existing horror show. so, we need to not clip damage at all when > backing store is enabled, so the fix in xserver is incomplete. Backing store has been reimplemented in terms of Composite, so is this valid now?
https://gitlab.freedesktop.org/xorg/xserver/issues/331
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.