Bug 3793 - dbus-0.34 and glib detection
Summary: dbus-0.34 and glib detection
Status: RESOLVED FIXED
Alias: None
Product: dbus
Classification: Unclassified
Component: core (show other bugs)
Version: unspecified
Hardware: All All
: lowest minor
Assignee: Havoc Pennington
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-07-16 07:05 UTC by Roumen Petrov
Modified: 2006-08-01 10:26 UTC (History)
0 users

See Also:
i915 platform:
i915 features:


Attachments
check version requirement plus other minor fixes (1.46 KB, patch)
2005-08-15 14:02 UTC, Roumen Petrov
Details | Splinter Review

Description Roumen Petrov 2005-07-16 07:05:14 UTC
some source files in glib subdirectory include "glib/gi18n.h".
glib cvs show taht this file appear for first time in GLIB_2_3_1 tag.

on system glib 2.2.x ./configure script detect it, but later make fail in glib
subdirectory.

what about two lines in configure script:
------------------
# Glib detection
PKG_CHECK_MODULES(DBUS_GLIB, gobject-2.0, have_glib=yes, have_glib=no)
PKG_CHECK_MODULES(DBUS_GLIB_THREADS, glib-2.0 gthread-2.0,
have_glib_threads=yes, have_glib_threads=no)
------------------

to be changed as follow:
------------------
# Glib detection
PKG_CHECK_MODULES(DBUS_GLIB, gobject-2.0 >= 2.4, have_glib=yes, have_glib=no)
PKG_CHECK_MODULES(DBUS_GLIB_THREADS, gthread-2.0 >= 2.4, have_glib_threads=yes,
have_glib_threads=no)
------------------
note gthread-2.0 require glib-2.0 and we can exclude 'glib-2.0' from second check.


What about warning/error message:
{...}GLib development libraries not found
to be changed to:
{...}GLib>=2.4 development package not found
Comment 1 Colin Walters 2005-08-10 02:06:30 UTC
Created attachment 3310 [details] [review]
Makefile-bsd-fix.patch

We probably depend on other post-2.4 APIs, so bumping the version requirement
seems best to me for now.  If people complain about 2.4 we can investigate
removing the dependency.
Comment 2 Roumen Petrov 2005-08-15 14:02:33 UTC
Created attachment 2885 [details] [review]
check version requirement plus other minor fixes

Colin, attachment with id=3310 is missing .

About new patch:

A.) changes in "./configure.in":
1.) check for versions of gobject-2.0 and gthread-2.0 >= 2.4
2.) replace obsolete AC_INIT(file_name) with correct macros
3.) move AC_CANONICAL_TARGET before AM_INIT_AUTOMAKE - suppress autoconf
warnings

B.) changes in "./dbus/dbus-arch-deps.h.in":
1.) removed ";" at end to suppress compiler warnings


What about message "GLib development libraries not found" ?
Usualy libs are installed on host system, but missing are headers.
Note some OS-ses put headers in separate "development package".
*.pc files should be in "development package" too and message "GLib development
libraries not found" confuse me.
Comment 3 John (J5) Palmieri 2005-08-24 22:21:49 UTC
What is the status of this?  Can I close?
Comment 4 John (J5) Palmieri 2005-09-06 14:56:53 UTC
configure.in now requires version 2.4 of glib (and related libraries) for
building the bindings.


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.