Bug 37933 - Initial work supporting contact blocking.
Summary: Initial work supporting contact blocking.
Status: RESOLVED FIXED
Alias: None
Product: Telepathy
Classification: Unclassified
Component: haze (show other bugs)
Version: unspecified
Hardware: Other All
: medium normal
Assignee: Telepathy bugs list
QA Contact: Telepathy bugs list
URL: http://cgit.collabora.com/git/user/wj...
Whiteboard:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2011-06-04 15:23 UTC by Jasper St. Pierre
Modified: 2011-08-02 04:00 UTC (History)
0 users

See Also:
i915 platform:
i915 features:

Attachments
against master (3.77 KB, patch)
2011-06-04 15:23 UTC, Jasper St. Pierre 		Details | Splinter Review
[PATCH 1/2] Blocking: implement can_block and add to Conn.Interfaces (2.15 KB, patch)
2011-06-09 05:42 UTC, Will Thompson 		Details | Splinter Review
[PATCH 2/2] Emit change notifications for blocked contacts (2.56 KB, patch)
2011-06-09 05:42 UTC, Will Thompson 		Details | Splinter Review
View All

Description Jasper St. Pierre 2011-06-04 15:23:37 UTC 
Created attachment 47540 [details] [review]
against master

Contact blocking. Haze. Stuff.
Comment 1 Will Thompson 2011-06-09 05:41:26 UTC 
Great start! Here are a couple more patches. With these, the blocking dialog in Empathy is functional, at least on AIM.

Tested:

• Blocking and unblocking a contact while connected.
• Blocking, disconnecting, waiting for Haze to die, then reconnecting, to verify that the contact being blocked is correctly sent to, and retrieved from, the server (rather than just being stored locally).
Comment 2 Will Thompson 2011-06-09 05:42:20 UTC 
Created attachment 47765 [details] [review]
[PATCH 1/2] Blocking: implement can_block and add to Conn.Interfaces
Comment 3 Will Thompson 2011-06-09 05:42:59 UTC 
Created attachment 47766 [details] [review]
[PATCH 2/2] Emit change notifications for blocked contacts
Comment 4 Jasper St. Pierre 2011-06-10 23:21:17 UTC 
LGTM. If you've tested, push.
Comment 5 Will Thompson 2011-08-02 04:00:59 UTC 
Was released in 0.5.0!

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.