Bug 38036 - TpConnection: add Location support
Summary: TpConnection: add Location support
Status: RESOLVED MOVED
Alias: None
Product: Telepathy
Classification: Unclassified
Component: tp-glib (show other bugs)
Version: unspecified
Hardware: Other All
: medium enhancement
Assignee: Telepathy bugs list
QA Contact: Telepathy bugs list
URL: http://cgit.collabora.com/git/user/ca...
Whiteboard:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2011-06-07 06:56 UTC by Guillaume Desmottes
Modified: 2019-12-03 20:38 UTC (History)
0 users

See Also:
i915 platform:
i915 features:


Attachments

Description Guillaume Desmottes 2011-06-07 06:56:56 UTC
In order to properly fix https://bugzilla.gnome.org/show_bug.cgi?id=651776 we should add Location support to TpConnection.
Comment 1 Guillaume Desmottes 2011-06-08 06:07:36 UTC
http://cgit.collabora.com/git/user/cassidy/telepathy-glib/log/?h=location-38036

I only added API on the features as:
- LocationAccessControl doesn't have a signal so we wouldn't be able to update the property
- I'm not sure how we want to represent location; maybe we want something better than a TpAsv?
- That's all I need to fix the Empathy bug :)

But that shouldn't block review and merge of this branch.
Comment 2 Simon McVittie 2011-06-08 06:45:06 UTC
(In reply to comment #1)
> - I'm not sure how we want to represent location; maybe we want something
> better than a TpAsv?

It'd be good to follow tp-qt4's lead and return an opaque thing (GObject, or possibly boxed struct), with convenience accessors for the well-known keys (tp_location_get_latitude() etc.) plus a way to peek at the actual contents. Migrating to GDBus or changing the D-Bus API would break the API of the latter but not the former.

Complications for the convenience API:

* everything needs to be "nullable" ("not known" is always a possible answer)

* some properties only make sense in groups - e.g. perhaps have:

    /**
     * lat: (out): latitude in degrees north (negative if south of the Equator),
     *    undefined if %FALSE is returned
     * lat: (out): longitude in degrees east (negative if west of Greenwich),
     *    undefined if %FALSE is returned
     * Returns: %TRUE if both @lat and @long are meaningful
     */
    gboolean tp_location_get_coordinates (TpLocation *, gdouble *lat,
        gdouble *long);
Comment 3 GitLab Migration User 2019-12-03 20:38:26 UTC
-- GitLab Migration Automatic Message --

This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/telepathy/telepathy-glib/issues/67.


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.