Bug 3809 - A couple of tests fail when --enable-indirect-deps is used
Summary: A couple of tests fail when --enable-indirect-deps is used
Alias: None
Product: pkg-config
Classification: Unclassified
Component: src (show other bugs)
Version: unspecified
Hardware: All All
: medium trivial
Assignee: Tollef Fog Heen
QA Contact:
Depends on:
Reported: 2005-07-18 23:23 UTC by Daniel Stone
Modified: 2010-08-19 12:24 UTC (History)
2 users (show)

See Also:
i915 platform:
i915 features:


Description FreeDesktop Bugzilla Database Corruption Fix User 2005-07-18 23:23:44 UTC
There's a couple of tests under the check folder that fail when
--enable-indirect-deps are passed to the configure script. Namely, check-libs
and check-requires-private.

I'll attach a short patch I created against CVS HEAD to correct this, in case
you want to review it.

Comment 1 FreeDesktop Bugzilla Database Corruption Fix User 2005-07-18 23:24:20 UTC
Created attachment 3104 [details]
Xorg.0.log with Option "MonitorLayout" "CRT,NONE"
Comment 2 Daniel Macks 2005-08-12 10:50:32 UTC
Present on OS X also (pkg-config 0.18.1)
(glad I finally found this bugzilla!)

I think it would be better to adjust the tests to what *should* happen instead
of just skipping those tests. Otherwise we'll never know if what those tests are
supposed to test is working. Perhaps have alternate check-libs and
check-requires-private test cases.
Comment 3 Daniel Macks 2005-10-14 12:16:15 UTC
I don't think I created this bugzilla item...why isn't the original comment (and
the patch I was discussing) here any more? Why is the "Opened by" name missing
in the 0th comment? Am I going crazy here? 
Comment 4 Daniel Macks 2005-11-29 07:24:04 UTC
Still broken in 0.20. Could we get some feedback here about how to proceed?
Comment 5 Tollef Fog Heen 2005-11-29 20:45:04 UTC
Bugzilla on fd.o has a small breakdown some time ago.

I haven't gotten around to investigating it, if you provide a patch, I can apply and test it, else I'll 
have to develop one myself, which takes more time.
Comment 6 Daniel Macks 2005-12-01 17:56:57 UTC
The issue with FAIL:check-libs is what *should* happen with *.private fields
when --enable-indirect-deps is used. That is, for simple.pc:

  Libs: -lsimple
  Libs.private: -lm

should --libs be seeing -lm or not? I think not, since the whole idea of
.private (as I understand it) is that it is for things used when libsimple was
built but that are not exposed to things built against libsimple. It's something
even less than an indirect dependency, which libsimple exposes to callers and so
callers might (depending on linker features) need to link themselves as well.

I see that Cflags/Cflags.private is implemented the other way:

  Cflags: -Dpublic
  Cflags.private: -Dprivate

pkg-config --cflags gives -Dpublic only (there does not appear to be a test of
this mode).
Comment 7 Daniel Macks 2005-12-01 19:09:29 UTC
*duh*, there's no such thing as Cflags.private. Please disregard my
over-reaching here.

Okay, looking at main.c, --enable-indirect-deps from ./configure merely sets
pkg-config to assume --static at runtime. So the test says that this is behaving
"correctly as implemented". However, this is not what the test expects, which
appears to be that indirect means "recurse down the Requires: web only", not
"and also merge every foo.private: into its associated foo:".
Comment 8 Tollef Fog Heen 2010-08-19 12:24:37 UTC
I believe this bug is fixed in 0.25 at least, so closing this.  Please reopen if you still see it.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.