Bug 38166 - test-debug.py should check for silence when DEBUGGING is disabled.
Summary: test-debug.py should check for silence when DEBUGGING is disabled.
Status: RESOLVED FIXED
Alias: None
Product: Telepathy
Classification: Unclassified
Component: gabble (show other bugs)
Version: git master
Hardware: Other All
: medium enhancement
Assignee: Telepathy bugs list
QA Contact: Telepathy bugs list
URL: http://cgit.collabora.com/git/user/al...
Whiteboard: review+
Keywords: patch
Depends on:
Blocks:
 
Reported: 2011-06-10 11:33 UTC by David Laban
Modified: 2011-07-06 12:41 UTC (History)
1 user (show)

See Also:
i915 platform:
i915 features:

Attachments

Description David Laban 2011-06-10 11:33:54 UTC 
I wrote this patch while testing #33903 in rakia and thought I should probably contribute my changes back to gabble.

Note that previously, test-debug.py doesn't actually "# Turn signalling off and check we have no new messages." (so that comment is wrong) because it doesn't actually spend any time in the mainloop between making the snapshot and testing for equality.
Comment 1 Will Thompson 2011-07-06 12:07:45 UTC 
Looks good! please ship it.
Comment 2 David Laban 2011-07-06 12:41:34 UTC 
Cherry-picked to master.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.