Bug 38280 - [bisected] regression : etqw tree/water wrong rendering
Summary: [bisected] regression : etqw tree/water wrong rendering
Status: RESOLVED FIXED
Alias: None
Product: Mesa
Classification: Unclassified
Component: Drivers/Gallium/r600 (show other bugs)
Version: git
Hardware: Other All
: medium normal
Assignee: Default DRI bug account
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-06-14 00:57 UTC by Pierre-Eric Pelloux-Prayer
Modified: 2012-08-23 17:55 UTC (History)
1 user (show)

See Also:
i915 platform:
i915 features:


Attachments
incorrect rendering (294.01 KB, image/jpeg)
2011-06-14 00:57 UTC, Pierre-Eric Pelloux-Prayer
Details
correct rendering for comparison (267.48 KB, image/jpeg)
2011-06-14 00:57 UTC, Pierre-Eric Pelloux-Prayer
Details
patch (1.59 KB, patch)
2011-06-14 10:44 UTC, Vadim Girlin
Details | Splinter Review

Description Pierre-Eric Pelloux-Prayer 2011-06-14 00:57:20 UTC
Created attachment 47923 [details]
incorrect rendering

commit 9346d895e7ff6c1f01b46513694542026ffba5cc broke tree and water rendering in etqw (Island map)
See attached screenshots.

I'm using r600g + HD4850
Comment 1 Pierre-Eric Pelloux-Prayer 2011-06-14 00:57:56 UTC
Created attachment 47924 [details]
correct rendering for comparison
Comment 2 Sven Arvidsson 2011-06-14 05:15:19 UTC
Interesting, I get the opposite behaviour on my HD5670. 

Rendering of trees and water is fixed with commit 9346d89, otherwise broken in the same way as in your screenshot.

I wonder if this means that the same commit broke rendering in Doom3 on non-Evergreen hardware?
Comment 3 Andy Furniss 2011-06-14 05:54:32 UTC
(In reply to comment #2)

> I wonder if this means that the same commit broke rendering in Doom3 on
> non-Evergreen hardware?

Yes. with current master on 4890 there is no distortion behind glass, there is with 9346d895e7ff6c1f01b46513694542026ffba5cc reverted.

Also see the same regression as the OP in etqw.
Comment 4 Vadim Girlin 2011-06-14 10:44:29 UTC
Created attachment 47965 [details] [review]
patch

This patch should restore previous behaviour for r600&r700 hw.
Comment 5 Pierre-Eric Pelloux-Prayer 2011-06-15 00:27:58 UTC
(In reply to comment #4)
> This patch should restore previous behaviour for r600&r700 hw.

Just tested it on ETQW, water and trees are properly rendering.
Comment 6 Andy Furniss 2011-06-15 02:21:07 UTC
(In reply to comment #4)
> Created an attachment (id=47965) [details]
> patch
> 
> This patch should restore previous behaviour for r600&r700 hw.

Works for me with etqw and doom3-demo.
Comment 7 Andreas Boll 2012-08-23 17:55:30 UTC
fixed with:

commit 016621ee142682153cb292cd3774e6d9377871ae
Author: Vadim Girlin <vadimgirlin@gmail.com>
Date:   Tue Jun 14 21:11:04 2011 +0400

    r600: fix SPI inputs setup on r600/r700
    
    Signed-off-by: Vadim Girlin <vadimgirlin@gmail.com>
    Signed-off-by: Dave Airlie <airlied@redhat.com>


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.