Bug 38365 - Argument builders should use '--' before user's name
Summary: Argument builders should use '--' before user's name
Status: RESOLVED FIXED
Alias: None
Product: accountsservice
Classification: Unclassified
Component: general (show other bugs)
Version: unspecified
Hardware: Other All
: medium normal
Assignee: Matthias Clasen
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-06-16 04:04 UTC by Rodrigo Moya
Modified: 2011-07-19 07:57 UTC (History)
0 users

See Also:
i915 platform:
i915 features:

Attachments
Patch to add '--' to argument builders (10.06 KB, patch)
2011-06-16 04:05 UTC, Rodrigo Moya 		Details | Splinter Review
View All

Description Rodrigo Moya 2011-06-16 04:04:24 UTC 
Even though the gnome-control-center panel checks the user name to not allow '-' as the first character in the name, it is probably safe to be using '--' before the user's name when spawning the command line tools to avoid any problem.

So attached patch fixes it
Comment 1 Rodrigo Moya 2011-06-16 04:05:26 UTC 
Created attachment 48031 [details] [review]
Patch to add '--' to argument builders
Comment 2 Matthias Clasen 2011-06-16 04:16:51 UTC 
As I already said on irc: patch looks fine to me.
Comment 3 Ray Strode [halfline] 2011-07-19 07:57:49 UTC 
looks like a good robustness fix. thanks.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.