Bug 38420 - Xvfb crashes in miInitVisuals () when started with depth=2
Summary: Xvfb crashes in miInitVisuals () when started with depth=2
Status: RESOLVED FIXED
Alias: None
Product: xorg
Classification: Unclassified
Component: Server/DDX/Xvfb (show other bugs)
Version: 7.6 (2010.12)
Hardware: x86-64 (AMD64) Linux (All)
: medium critical
Assignee: Alan Coopersmith
QA Contact: Xorg Project Team
URL: https://bugzilla.novell.com/show_bug....
Whiteboard: 2011BRB_Reviewed
Keywords: patch
Depends on:
Blocks:
 
Reported: 2011-06-17 10:56 UTC by Christopher Yeleighton
Modified: 2011-10-24 19:03 UTC (History)
0 users

See Also:
i915 platform:
i915 features:

Attachments
do not crash, fail! (356 bytes, patch)
2011-06-17 12:05 UTC, Christopher Yeleighton 		no flags Details | Splinter Review
View All

Description Christopher Yeleighton 2011-06-17 10:56:43 UTC 
{ Xvfb :1 -screen 0 10x10x2; }

Program received signal SIGSEGV, Segmentation fault.
0x0000000000543830 in miInitVisuals (visualp=0x7fffffffe478,
depthp=0x7fffffffe470, nvisualp=0x7fffffff0001, ndepthp=<value optimized out>,
rootDepthp=0x7fffffffe484, defaultVisp=0x7fffffffe480, sizes=128, bitsPerRGB=8,
preferredVis=-1) at micmap.c:664
664       *defaultVisp = depth[i].vids[j];

openSuSE Bug 698125

The offending code in vfbSceenInit is not patched, so reporting upstream.
Comment 1 Christopher Yeleighton 2011-06-17 12:05:44 UTC 
Created attachment 48114 [details] [review]
do not crash, fail!

Whereas I would very much like to have real support for bit depth 2, this patch at least prevents the server from crashing.
Comment 2 Alan Coopersmith 2011-09-23 20:44:45 UTC 
Thanks for fix - submitted to xorg-devel for review for Xorg 1.12 merge window.
Comment 3 Jeremy Huddleston Sequoia 2011-10-11 01:03:22 UTC 
It slipped through the cracks on xorg-devel, but I just resurrected it with a 
review.
Comment 4 Alan Coopersmith 2011-10-24 19:03:59 UTC 
Fix applied to git master, thanks:
http://cgit.freedesktop.org/xorg/xserver/commit/?id=7d50211ab57a35910d79fc3f67ae89aff91fa995

As for someday supporting other bit depths, going forward it seems
like Xorg with the xf86-video-dummy driver is going to get more
attention than Xvfb, so seeing how well that works would be the
next step I'd suggest.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.