Bug 38559 - Add tp_text_channel_ack_all_pending_messages()
Summary: Add tp_text_channel_ack_all_pending_messages()
Status: RESOLVED FIXED
Alias: None
Product: Telepathy
Classification: Unclassified
Component: tp-glib (show other bugs)
Version: unspecified
Hardware: Other All
: medium enhancement
Assignee: Telepathy bugs list
QA Contact: Telepathy bugs list
URL: http://cgit.collabora.com/git/user/ca...
Whiteboard: review+
Keywords: patch
Depends on:
Blocks:
 
Reported: 2011-06-22 03:14 UTC by Guillaume Desmottes
Modified: 2011-06-22 05:29 UTC (History)
0 users

See Also:
i915 platform:
i915 features:


Attachments
add tp_text_channel_ack_all_pending_messages_async() (#38559) (6.70 KB, patch)
2011-06-22 03:36 UTC, Guillaume Desmottes
Details | Splinter Review

Description Guillaume Desmottes 2011-06-22 03:14:14 UTC
So clients wouldn't have to keep their own list of unacked messages. Furthermore, they should always ack all the messages, even those they don't understand, keeping messages unacked isn't helpful: channel will always be respawned and messages will stay in memory forever.
Comment 2 Guillaume Desmottes 2011-06-22 03:36:35 UTC
Created attachment 48276 [details] [review]
add tp_text_channel_ack_all_pending_messages_async() (#38559)
Comment 3 Jonny Lamb 2011-06-22 03:59:34 UTC
Are we depending on late enough glib for _take_error()? 

+ * Finishes to ack all the pending of messages.

"Finish an asynchronous acknowledgement operation of all messages" I think would be better.

++ otherwise
Comment 4 Guillaume Desmottes 2011-06-22 04:36:33 UTC
(In reply to comment #3)
> Are we depending on late enough glib for _take_error()? 

Yep, that's GLib 2.28 on which we depend already (probably for this function
actually).

> + * Finishes to ack all the pending of messages.
> 
> "Finish an asynchronous acknowledgement operation of all messages" I think
> would be better.

fixed.
Comment 5 Guillaume Desmottes 2011-06-22 05:29:02 UTC
Merged to master; will be in 0.15.3.


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.