Bug 38626 - vbo: Don't discount stride breaks piglit on softpipe/r600g
Summary: vbo: Don't discount stride breaks piglit on softpipe/r600g
Status: RESOLVED FIXED
Alias: None
Product: Mesa
Classification: Unclassified
Component: Mesa core (show other bugs)
Version: git
Hardware: Other All
: medium normal
Assignee: mesa-dev
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-06-23 16:59 UTC by Rafael Monica
Modified: 2011-06-24 09:42 UTC (History)
0 users

See Also:
i915 platform:
i915 features:

Attachments
restore the old vbo_all_varyings_in_vbos() behavior in st_draw.c only (1.04 KB, patch)
2011-06-23 17:39 UTC, Brian Paul 		Details | Splinter Review
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Rafael Monica 2011-06-23 16:59:40 UTC 
the commit:

commit d631c19db47181129811080bfa772b210d762d4d
Author: Eric Anholt <eric@anholt.net>
Date:   Fri Jun 17 13:17:34 2011 -0700

    vbo: Don't discount stride == 0 for testing all varyings in VBOs.


breaks:

draw-elements-base-vertex
draw-elements-base-vertex-neg

on r600g, and:

draw-elements-base-vertex

on softpipe.
Comment 1 Brian Paul 2011-06-23 17:39:18 UTC 
Created attachment 48361 [details] [review]
restore the old vbo_all_varyings_in_vbos() behavior in st_draw.c only

I'm not seeing the failure with softpipe (or llvmpipe).

In any case, can you try this patch?
Comment 2 Rafael Monica 2011-06-23 17:57:06 UTC 
Yeah, the patch fixes the regression.
Comment 3 Brian Paul 2011-06-24 09:42:42 UTC 
Committed.  d91dc4a356e5509116572770b89d0a7520a55bfc

bug/show.html.tmpl processed on Mar 20, 2017 at 09:50:17.
(provided by the Example extension).