Bug 38858 - [regression] build failure in module-jack-sink.c:463: undefined reference to `jack_free'
Summary: [regression] build failure in module-jack-sink.c:463: undefined reference to ...
Status: RESOLVED FIXED
Alias: None
Product: PulseAudio
Classification: Unclassified
Component: modules (show other bugs)
Version: unspecified
Hardware: x86 (IA32) Linux (All)
: medium critical
Assignee: pulseaudio-bugs
QA Contact: pulseaudio-bugs
URL:
Whiteboard: triaged
Keywords:
Depends on:
Blocks:
 
Reported: 2011-06-30 18:50 UTC by David Ronis
Modified: 2011-08-15 10:07 UTC (History)
2 users (show)

See Also:
i915 platform:
i915 features:


Attachments

Description David Ronis 2011-06-30 18:50:53 UTC
I just tried upgrading form 0.22 to 0.23.  The build fails as mentioned in the summary.   Here's the full log:
bin/sh ../libtool  --tag=CC   --mode=link /usr/bin/gcc -std=gnu99 -I../src -I../src -I../src/modules -I../src/modules -I../src/modules/rtp -I../src/modules/rtp -I../src/modules/gconf -I../src/modules/gconf -I../src/modules/bluetooth -I../src/modules/bluetooth -I../src/modules/oss -I../src/modules/oss -I../src/modules/alsa -I../src/modules/alsa -I../src/modules/raop -I../src/modules/raop -I../src/modules/x11 -I../src/modules/x11 -I../src/modules/jack -I../src/modules/jack -I../src/modules/echo-cancel -I../src/modules/echo-cancel -pthread -D_POSIX_PTHREAD_SEMANTICS  -I/usr/local/include   -I/usr/local/include   -DPA_BUILDDIR=\"/home/ronis/Project/notar/GNOME/garnome/desktop/pulseaudio/work/main.d/pulseaudio-0.9.23/src\" -DPA_DLSEARCHPATH=\"/opt/garnome-svn-3.1.1/lib/pulse-0.9.23/modules\" -DPA_DEFAULT_CONFIG_DIR=\"/opt/garnome-svn-3.1.1/etc/pulse\" -DPA_BINARY=\"/opt/garnome-svn-3.1.1/bin/pulseaudio\" -DPA_SYSTEM_RUNTIME_PATH=\"/opt/garnome-svn-3.1.1/var/run/pulse\" -DPA_SYSTEM_CONFIG_PATH=\"/opt/garnome-svn-3.1.1/var/lib/pulse\" -DPA_SYSTEM_STATE_PATH=\"/opt/garnome-svn-3.1.1/var/lib/pulse\" -DAO_REQUIRE_CAS -DPULSE_LOCALEDIR=\"/opt/garnome-svn-3.1.1/share/locale\" -DPA_MACHINE_ID=\"/opt/garnome-svn-3.1.1/var/lib/dbus/machine-id\" -DPA_ALSA_PATHS_DIR=\"/opt/garnome-svn-3.1.1/share/pulseaudio/alsa-mixer/paths\" -DPA_ALSA_PROFILE_SETS_DIR=\"/opt/garnome-svn-3.1.1/share/pulseaudio/alsa-mixer/profile-sets\" -I/usr/local/include   -I/opt/garnome-svn-3.1.1/include -L/opt/garnome-svn-3.1.1/lib -O2 -g -pipe -Wall -W -Wextra -pipe -Wno-long-long -Winline -Wvla -Wno-overlength-strings -Wunsafe-loop-optimizations -Wundef -Wformat=2 -Wlogical-op -Wsign-compare -Wformat-security -Wmissing-include-dirs -Wformat-nonliteral -Wold-style-definition -Wpointer-arith -Winit-self -Wdeclaration-after-statement -Wfloat-equal -Wmissing-prototypes -Wstrict-prototypes -Wredundant-decls -Wmissing-declarations -Wmissing-noreturn -Wshadow -Wendif-labels -Wcast-align -Wstrict-aliasing=2 -Wwrite-strings -Wno-unused-parameter -ffast-math -Wp,-D_FORTIFY_SOURCE=2 -fno-common -fdiagnostics-show-option -module -disable-static -avoid-version -Wl,--no-undefined -Wl,--export-dynamic -L/opt/garnome-svn-3.1.1/lib -o module-jack-sink.la -rpath /opt/garnome-svn-3.1.1/lib/pulse-0.9.23/modules module_jack_sink_la-module-jack-sink.lo   libpulsecore-0.9.23.la -L/usr/local/lib -ljack   libpulsecommon-0.9.23.la libpulse.la -lcap -lrt -ldl -lm 
libtool: link: /usr/bin/gcc -shared  -fPIC -DPIC  .libs/module_jack_sink_la-module-jack-sink.o   -Wl,-rpath -Wl,/home/ronis/Project/notar/GNOME/garnome/desktop/pulseaudio/work/main.d/pulseaudio-0.9.23/src/.libs -Wl,-rpath -Wl,/opt/garnome-svn-3.1.1/lib -Wl,-rpath -Wl,/opt/garnome-svn-3.1.1/lib -L/home/ronis/Project/notar/GNOME/garnome/desktop/pulseaudio/work/main.d/pulseaudio-0.9.23/src/.libs -L/opt/garnome-svn-3.1.1/lib ./.libs/libpulsecore-0.9.23.so -L/usr/lib -L/usr/local/lib -L/usr/local/samba/lib /opt/garnome-svn-3.1.1/lib/libltdl.so /usr/lib/libsamplerate.so /usr/local/lib/libspeexdsp.so /home/ronis/Project/notar/GNOME/garnome/desktop/pulseaudio/work/main.d/pulseaudio-0.9.23/src/.libs/libpulse.so -ltdb /usr/local/lib/libjack.so ./.libs/libpulsecommon-0.9.23.so ./.libs/libpulse.so /home/ronis/Project/notar/GNOME/garnome/desktop/pulseaudio/work/main.d/pulseaudio-0.9.23/src/.libs/libpulsecommon-0.9.23.so /usr/lib/libX11-xcb.so /usr/lib/libSM.so /usr/lib/libICE.so /usr/lib/libuuid.so /usr/lib/libXtst.so /usr/lib/libXi.so /usr/lib/libXext.so /usr/lib/libX11.so /usr/lib/libxcb.so /usr/lib/libXau.so /usr/lib/libXdmcp.so /opt/garnome-svn-3.1.1/lib/libiconv.so /usr/local/lib/libsndfile.so /opt/garnome-svn-3.1.1/lib/libdbus-1.so -lpthread -lcap -lrt -ldl -lm  -pthread -O2 -Wl,--no-undefined -Wl,--export-dynamic   -pthread -Wl,-soname -Wl,module-jack-sink.so -o .libs/module-jack-sink.so
.libs/module_jack_sink_la-module-jack-sink.o: In function `module_jack_sink_LTX_pa__init':
/home/ronis/Project/notar/GNOME/garnome/desktop/pulseaudio/work/main.d/pulseaudio-0.9.23/src/modules/jack/module-jack-sink.c:463: undefined reference to `jack_free'
/home/ronis/Project/notar/GNOME/garnome/desktop/pulseaudio/work/main.d/pulseaudio-0.9.23/src/modules/jack/module-jack-sink.c:453: undefined reference to `jack_free'
Comment 1 Colin Guthrie 2011-07-01 07:45:00 UTC
Hmm, I see -ljack in the compile string there which is where jack_free lives AFAICT... And this is translated to  /usr/local/lib/libjack.so in the linking stage.

Are you sure that this lib is correct and up-to-date? It works fine here linking against my libjack, so not sure if this is just something strange with your setup.

This was a change in .22 -> .23 that introduced the use of jack_free, but I wonder if this is something that was introduced only in newer versions of jack...

I'll assign this to David as he was the one who pushed the patch (only I don't know which email he uses here, so I'll have to do that later when I can get hold of him :D)

http://cgit.freedesktop.org/pulseaudio/pulseaudio/commit/?h=stable-queue&id=fd5b282f51ab69d32b4ee3fcd1f8ed7fc3004ff6
Comment 2 David Ronis 2011-07-01 10:05:34 UTC
That was it.   My libjack was versuion 0.23, upgrading to 0.28 fixes the problem.
Comment 3 Colin Guthrie 2011-07-03 07:15:44 UTC
It is actually a bug as we do still need to check for an appropriate version of libjack if we're going to use functions introduced in a later version :)
Comment 4 Tanu Kaskinen 2011-07-20 09:12:24 UTC
Adding "triaged" to the whiteboard.
Comment 5 Arun Raghavan 2011-08-15 10:07:02 UTC
commit 16147ae8283cb634f55e76f63395a599a69b78b5
Author: Arun Raghavan <arun.raghavan@collabora.co.uk>
Date:   Mon Aug 15 22:31:55 2011 +0530

    build-sys: Bump JACK dependency to 0.117.0
    
    This version is required since we recently started using jack_free()
    
    https://bugs.freedesktop.org/show_bug.cgi?id=38858


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.