Bug 38959 - bashism in xdg-open
Summary: bashism in xdg-open
Status: RESOLVED FIXED
Alias: None
Product: Portland
Classification: Unclassified
Component: xdg-utils (show other bugs)
Version: 1.1.0 rc1
Hardware: All All
: medium normal
Assignee: Portland Bugs
QA Contact:
URL:
Whiteboard:
Keywords:
: 44356 (view as bug list)
Depends on:
Blocks:
 
Reported: 2011-07-04 13:58 UTC by Faustus
Modified: 2012-03-02 11:35 UTC (History)
1 user (show)

See Also:
i915 platform:
i915 features:

Attachments

Description Faustus 2011-07-04 13:58:35 UTC 
elif [ x"$DESKTOP_SESSION" == x"LXDE" ]; then DE=lxde;

"==" should be "="

That line produces an error in dash.
Comment 1 Rex Dieter 2011-07-05 09:25:17 UTC 
this is fixed in git, that code was refactored into a case statement to no longer include any explicit == or = comparisons
Comment 2 Faustus 2011-07-28 03:00:50 UTC 
According to
  http://cgit.freedesktop.org/xdg/xdg-utils/tree/scripts/
the aforementioned == comparison appears in
  xdg-desktop-icon
  xdg-desktop-menu
  xdg-email
  xdg-icon-resource
  xdg-mime
  xdg-open
  xdg-screensaver
  xdg-settings
  xdg-terminal (many times)
Am I looking at the wrong tree?
Comment 3 Rex Dieter 2011-08-11 06:37:48 UTC 
Those are all generated files.

Look in all the *.in ones instead.
Comment 4 Rex Dieter 2011-08-11 07:03:45 UTC 
OK, I went ahead and checked myself, and there are some remaining...

looks like I only fixed the particular example you mentioned in your initial comment.
Comment 6 Rex Dieter 2012-03-02 11:35:30 UTC 
*** Bug 44356 has been marked as a duplicate of this bug. ***

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.