Bug 3897 - Xnest should shut down cleanly when you close its window
Summary: Xnest should shut down cleanly when you close its window
Status: RESOLVED MOVED
Alias: None
Product: xorg
Classification: Unclassified
Component: Server/DDX/Xnest (show other bugs)
Version: git
Hardware: x86 (IA32) Linux (All)
: high normal
Assignee: Xorg Project Team
QA Contact: Xorg Project Team
URL:
Whiteboard: 2011BRB_Reviewed
Keywords:
Depends on:
Blocks:
 
Reported: 2005-07-28 04:41 UTC by Mark McLoughlin
Modified: 2018-12-17 17:21 UTC (History)
0 users

See Also:
i915 platform:
i915 features:


Attachments

Description Mark McLoughlin 2005-07-28 04:41:41 UTC
If you close an Xnest window via the window manager, the WM has no choice but to
do XKillClient() since Xnest doesn't support the WM_DELETE_WINDOW protocol.

Because of this, it doesn't shut down cleanly and e.g. doesn't delete its lock file.

Attaching a patch to:

  1) Implement support for WM_DELETE_WINDOW

  2) Shutdown gracefully when using -parent and a DestroyNotify is received
     (because our parent has been destroyed, all sub-windows we created
      will have been destroyed too, so we need to avoid trying to destroy
      them again as we shut down)
Comment 1 Mark McLoughlin 2005-07-28 04:42:33 UTC
Created attachment 3166 [details] [review]
Unified patch for the Romanian layout (includes updated descriptions for base.xml.in)
Comment 2 Mark McLoughlin 2005-07-29 00:55:57 UTC
Created attachment 3180 [details]
log file when driver detects PLL parameters

Running a GNOME session on this through up some places where we need to prevent
against performing operations on destroyed windows at shutdown.
Comment 3 Mark McLoughlin 2005-07-29 23:31:16 UTC
Created attachment 3190 [details] [review]
proposed patch

Okay, more issues keep cropping up with GiveUp() when running in -parent mode.

So, I could continue the invasive auditing for places where we are accessing
destroyed resources on the backend server at shutdown, but its probably better
to just do CloseWellKnowConnections() and OsCleanup(True) before exiting.
Comment 4 Daniel Stone 2007-02-27 01:27:29 UTC
Sorry about the phenomenal bug spam, guys.  Adding xorg-team@ to the QA contact so bugs don't get lost in future.
Comment 5 Jeremy Huddleston Sequoia 2011-10-16 16:56:33 UTC
The referenced patches are not for this bug.

Mark, you referenced a patch.  Do you still have it?  Can you attach it?


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.