Bug 39176 - [965GM] pipe_assert_enabled() failed during get_load_detect_pipe for TV
Summary: [965GM] pipe_assert_enabled() failed during get_load_detect_pipe for TV
Status: CLOSED FIXED
Alias: None
Product: DRI
Classification: Unclassified
Component: DRM/Intel (show other bugs)
Version: unspecified
Hardware: x86 (IA32) Linux (All)
: medium critical
Assignee: Chris Wilson
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-07-12 11:51 UTC by Vinson Lee
Modified: 2017-07-24 23:04 UTC (History)
3 users (show)

See Also:
i915 platform:
i915 features:


Attachments

Description Vinson Lee 2011-07-12 11:51:38 UTC
Saw this crash with VMware Workstation.

System environment:
-- chipset: 965GM (Intel X3100)
-- system architecture: i686
-- xserver-xorg-video-intel: 2:2.15.0-3ubuntu2
-- xserver-common: 2:1.10.2.902-1ubuntu2
-- mesa: 7.11~1-0ubuntu3
-- libdrm: 2.4.26-1ubuntu1
-- kernel version: 3.0-3-generic
-- Linux distribution: Ubuntu 11.10


[ 3590.932122] ------------[ cut here ]------------
[ 3590.932147] WARNING: at /build/buildd/linux-3.0/drivers/gpu/drm/i915/intel_display.c:915 assert_pipe+0x75/0x80 [i915]()
[ 3590.932152] Hardware name: MacBook3,1
[ 3590.932155] pipe A assertion failure (expected on, current off)
[ 3590.932159] Modules linked in: vmmon parport_pc ppdev nfs lockd fscache auth_rpcgss nfs_acl sunrpc appletalk ipx p8023 snd_hda_codec_realtek snd_hda_intel snd_hda_codec appletouch snd_hwdep isight_firmware snd_pcm snd_seq_midi snd_rawmidi arc4 snd_seq_midi_event i915 b43 snd_seq binfmt_misc snd_timer snd_seq_device joydev snd soundcore snd_page_alloc drm_kms_helper mac80211 apple_bl drm i2c_algo_bit cfg80211 applesmc input_polldev video lp parport hid_apple usbhid hid firewire_ohci firewire_core crc_itu_t sky2 ssb
[ 3590.932227] Pid: 1936, comm: upowerd Tainted: G        W   3.0-3-generic #4-Ubuntu
[ 3590.932231] Call Trace:
[ 3590.932243]  [<c1047492>] warn_slowpath_common+0x72/0xa0
[ 3590.932259]  [<f86f6585>] ? assert_pipe+0x75/0x80 [i915]
[ 3590.932274]  [<f86f6585>] ? assert_pipe+0x75/0x80 [i915]
[ 3590.932279]  [<c1047563>] warn_slowpath_fmt+0x33/0x40
[ 3590.932294]  [<f86f6585>] assert_pipe+0x75/0x80 [i915]
[ 3590.932312]  [<f86fe5a6>] intel_enable_plane+0x26/0x70 [i915]
[ 3590.932329]  [<f8700a87>] i9xx_crtc_enable+0x77/0xa0 [i915]
[ 3590.932346]  [<f8700abd>] i9xx_crtc_commit+0xd/0x10 [i915]
[ 3590.932352]  [<f8266c08>] drm_crtc_helper_set_mode+0x338/0x420 [drm_kms_helper]
[ 3590.932374]  [<f8702ae2>] intel_get_load_detect_pipe+0x222/0x380 [i915]
[ 3590.932395]  [<f8716e14>] intel_tv_detect+0xb4/0x1b0 [i915]
[ 3590.932410]  [<f820d83a>] status_show+0x3a/0x80 [drm]
[ 3590.932423]  [<f820d800>] ? dpms_show+0x60/0x60 [drm]
[ 3590.932427]  [<c1339f3f>] dev_attr_show+0x1f/0x50
[ 3590.932431]  [<c1183eae>] fill_read_buffer.isra.7+0x4e/0xd0
[ 3590.932435]  [<c1183fad>] sysfs_read_file+0x7d/0x90
[ 3590.932439]  [<c1126c4c>] vfs_read+0x8c/0x160
[ 3590.932443]  [<c1183f30>] ? fill_read_buffer.isra.7+0xd0/0xd0
[ 3590.932447]  [<c1126d5d>] sys_read+0x3d/0x70
[ 3590.932451]  [<c1532204>] syscall_call+0x7/0xb
[ 3590.932455]  [<c1530000>] ? schedule+0x500/0x680
[ 3590.932457] ---[ end trace ac1d0bffd78eaadb ]---
[ 3591.252486] ------------[ cut here ]------------
Comment 1 Vinson Lee 2011-07-13 10:33:30 UTC
Another similar crash.

[ 3054.928488] ------------[ cut here ]------------
[ 3054.928511] WARNING: at /build/buildd/linux-3.0/drivers/gpu/drm/i915/intel_display.c:791 intel_enable_pipe+0x144/0x150 [i915]()
[ 3054.928514] Hardware name: MacBook3,1
[ 3054.928516] PLL state assertion failure (expected on, current off)
[ 3054.928517] Modules linked in: vmmon parport_pc ppdev nfs lockd fscache auth_rpcgss nfs_acl sunrpc appletalk ipx p8023 snd_hda_codec_realtek snd_hda_intel snd_hda_codec snd_hwdep snd_pcm isight_firmware snd_seq_midi hid_apple usbhid snd_rawmidi hid snd_seq_midi_event snd_seq appletouch i915 arc4 b43 snd_timer snd_seq_device joydev drm_kms_helper mac80211 snd drm cfg80211 soundcore snd_page_alloc binfmt_misc i2c_algo_bit applesmc apple_bl video input_polldev lp parport firewire_ohci firewire_core crc_itu_t sky2 ssb
[ 3054.928559] Pid: 5, comm: kworker/u:0 Not tainted 3.0-3-generic #4-Ubuntu
[ 3054.928561] Call Trace:
[ 3054.928570]  [<c1047492>] warn_slowpath_common+0x72/0xa0
[ 3054.928584]  [<f86fe574>] ? intel_enable_pipe+0x144/0x150 [i915]
[ 3054.928597]  [<f86fe574>] ? intel_enable_pipe+0x144/0x150 [i915]
[ 3054.928601]  [<c1047563>] warn_slowpath_fmt+0x33/0x40
[ 3054.928615]  [<f86fe574>] intel_enable_pipe+0x144/0x150 [i915]
[ 3054.928630]  [<f87003f9>] i9xx_crtc_mode_set+0x699/0xcb0 [i915]
[ 3054.928642]  [<f86d82e3>] ? i915_enable_vblank+0x23/0xf0 [i915]
[ 3054.928656]  [<f86f597b>] intel_crtc_mode_set+0x5b/0x80 [i915]
[ 3054.928662]  [<f825ebb2>] drm_crtc_helper_set_mode+0x2e2/0x420 [drm_kms_helper]
[ 3054.928667]  [<c1025f98>] ? default_spin_lock_flags+0x8/0x10
[ 3054.928675]  [<f825ed5d>] drm_helper_resume_force_mode+0x6d/0x140 [drm_kms_helper]
[ 3054.928686]  [<f86cff07>] i915_reset+0x167/0x3c0 [i915]
[ 3054.928690]  [<c10562f6>] ? add_timer+0x16/0x20
[ 3054.928701]  [<f86d45ce>] i915_error_work_func+0xae/0xf0 [i915]
[ 3054.928706]  [<c1060ce1>] process_one_work+0x101/0x3a0
[ 3054.928709]  [<c10614a5>] ? maybe_create_worker+0x15/0xe0
[ 3054.928712]  [<c1060bbe>] ? destroy_worker+0x7e/0xa0
[ 3054.928723]  [<f86d4520>] ? i915_driver_device_is_agp+0x10/0x10 [i915]
[ 3054.928727]  [<c10617a4>] worker_thread+0x124/0x2d0
[ 3054.928730]  [<c1061680>] ? manage_workers.isra.28+0x110/0x110
[ 3054.928733]  [<c10652bd>] kthread+0x6d/0x80
[ 3054.928736]  [<c1065250>] ? flush_kthread_worker+0x80/0x80
[ 3054.928741]  [<c153947e>] kernel_thread_helper+0x6/0x10
[ 3054.928743] ---[ end trace f2cc05cd8c0cf60f ]---
[ 3055.040130] ------------[ cut here ]------------
Comment 2 Chris Wilson 2011-07-29 01:06:38 UTC
I wonder if this is related to the plane-flushing fix:

commit 2704cf5fbd248871a745d210733c6319959d2b0c
Author: Jesse Barnes <jbarnes@virtuousgeek.org>
Date:   Thu Jul 28 11:52:45 2011 -0700

    drm/i915: flush plane control changes on ILK+ as well
    
    After writing to the plane control reg we need to write to the surface
    reg to trigger the double buffered register latch.  On previous
    chipsets, writing to DSPADDR was enough, but on ILK+ DSPSURF is the reg
    that triggers the double buffer latch.
    
    v2: write DSPADDR too to cover pre-965 chipsets
    v3: use flush_display_plane instead, that's what it's for
    v4: send the right patch
    
    Signed-off-by: Jesse Barnes <jbarnes@virtuousgeek.org>
    Tested-by: Keith Packard <keithp@keithp.com>
    Reviewed-by: Keith Packard <keithp@keithp.com>
    Signed-off-by: Keith Packard <keithp@keithp.com>

Can you please test keithp/drm-intel-fixes [ git://git.kernel.org/pub/scm/linux/kernel/git/keithp/drm-intel.git]
Comment 3 Chris Wilson 2012-03-26 05:52:18 UTC
Assuming the patch highlight did address the issue.


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.