Just reading at the code, it looks to me that SetAutomaticLogin is broken.
Let's assume that autologin is configured for Alice. Now, if we call SetAutomaticLogin(False) on the Bob user, autologin will be disabled. However, the expected behavior, imho, is that it should be disabled for Bob, but should not disable anything for Alice (unless SetAutomaticLogin(True) is used, obviously).
Created attachment 49345 [details] [review]
daemon: ignore extraneous SetAutomaticLogin(false) calls for a user
Right now, if a user is not configured for automatic login, and
SetAutomaticLogin(false) is called for that user then we disable
automatic login system wide even if someone else is configured
for automatic login.
This commit changes the semantics of the call such that
SetAutomaticLogin(false) is a no op for users where automatic login
isn't already enabled.
Spotted by Vincent Untz <email@example.com>
That patch look okay?
Looks sane to me.
Makes sense to me as well