Bug 40001 - gibber: Remove broken tests and dependency on xmldiff
Summary: gibber: Remove broken tests and dependency on xmldiff
Status: RESOLVED FIXED
Alias: None
Product: Telepathy
Classification: Unclassified
Component: salut (show other bugs)
Version: unspecified
Hardware: All All
: medium normal
Assignee: Telepathy bugs list
QA Contact: Telepathy bugs list
URL: http://cgit.collabora.com/git/user/st...
Whiteboard: review+
Keywords: patch
Depends on: 34255
Blocks:
  Show dependency tree / graph
 
Reported: 2011-08-11 03:30 UTC by Stef Walter
Modified: 2011-08-13 05:48 UTC (History)
0 users

See Also:
i915 platform:
i915 features:

Attachments
gibber: Remove broken tests and dependency on xmldiff (7.70 KB, patch)
2011-08-11 03:30 UTC, Stef Walter 		Details | Splinter Review
View All

Description Stef Walter 2011-08-11 03:30:20 UTC 
lib/gibber/tests/run-xmpp-connection-test.sh doesn't run successfully anyway and its dependencies seem to have been removed. Also remove the inputs/ subdirectory not used by anything else.
Comment 1 Stef Walter 2011-08-11 03:30:27 UTC 
Created attachment 50115 [details] [review]
gibber: Remove broken tests and dependency on xmldiff

* These tests don't run successfully anyway.
Comment 3 Jonny Lamb 2011-08-12 04:02:01 UTC 
Gogogogogo.

For the record, patches requiring review should add the "patch" keyword on the bug and set the URL field to your branch. I've done that now.
Comment 4 Stef Walter 2011-08-12 05:24:36 UTC 
Right. Sorry bout that. Can't use patch keyword or URL field on bgo, so I keep forgetting to do it here.

Hmmm doesn't look like I've been added to the telepathy group yet...
Comment 5 Stef Walter 2011-08-13 05:48:13 UTC 
Merged.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.