Bug 40008 - Detect telepathy-glib in right directory
Summary: Detect telepathy-glib in right directory
Alias: None
Product: Telepathy
Classification: Unclassified
Component: tp-qt (show other bugs)
Version: git master
Hardware: Other All
: medium normal
Assignee: Telepathy bugs list
QA Contact: Telepathy bugs list
URL: http://cgit.collabora.com/git/user/st...
Keywords: patch
Depends on:
Reported: 2011-08-11 05:52 UTC by Stef Walter
Modified: 2019-11-19 09:32 UTC (History)
1 user (show)

See Also:
i915 platform:
i915 features:

Ignore telepathy-glib installs in system when using another prefix (1.79 KB, patch)
2011-08-11 05:55 UTC, Stef Walter
Details | Splinter Review

Description Stef Walter 2011-08-11 05:52:34 UTC
If PKG_CONFIG_PATH is set (such as during jhbuild) telepathy-glib is detected in the alternate directory, but the libraries and include files are then used from the system directories.


$ pkg-config telepathy-glib --modversion
$ PKG_CONFIG_PATH=~/build/telepathy/lib64/pkgconfig pkg-config telepathy-glib --modversion
$ cd ~/projects/telepathy-qt4
$ PKG_CONFIG_PATH=~/build/telepathy/lib64/pkgconfig cmake .
-- checking for module 'telepathy-glib>=0.15.1'
--   found telepathy-glib, version
-- Found TelepathyGlib: /usr/lib64/libtelepathy-glib.so 
Comment 1 Stef Walter 2011-08-11 05:55:01 UTC
Created attachment 50123 [details] [review]
Ignore telepathy-glib installs in system when using another prefix

If using another build prefix PKG_CONFIG_PATH is set. This means that
pkg-config finds telepathy-glib.pc in the alternate prefix. However
if telepathy-glib is also installed, the cmake code then goes and uses
find_library/find_path, which by default use system directories.

Remove usage of system directories, in the case where the pkg-config file
is found.
Comment 2 Stef Walter 2011-08-11 05:55:46 UTC
After patch:

$ PKG_CONFIG_PATH=/data/build/telepathy/lib64/pkgconfig cmake .
-- checking for module 'telepathy-glib>=0.15.1'
--   found telepathy-glib, version
-- Found TelepathyGlib: /data/build/telepathy/lib64/libtelepathy-glib.so 
Comment 4 Stef Walter 2011-08-11 06:02:07 UTC
Oh and without this build patch I obviously get build failures for telepathy-glib features used in telepathy-qt4 but not in my system telepathy-glib.
Comment 5 George Kiagiadakis 2016-10-09 09:46:59 UTC
Afaik, find_path() and find_library() are meant to look first in the paths specified on their call, so they *should* use the pkg-config discovered paths BEFORE looking at the system paths. If this bug is still valid, I suspect there is something fishy about those PC_* variables. It may also have been a cmake bug at the time...

In any case, I am not convinced that this patch is the correct approach.
Comment 6 Alexandr Akulich 2019-11-19 09:32:21 UTC
We used to call find_library with PATHS option, but it has the lowest priority, this the standard system environment variables processed first. Use HINTS option to ensure the right order of lookup directories.

See also: https://cmake.org/cmake/help/latest/command/find_library.html


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.