Bug 4001 - X crashes unless PanelSize is set (caused by dereferencing NULL pointer)
Summary: X crashes unless PanelSize is set (caused by dereferencing NULL pointer)
Status: RESOLVED FIXED
Alias: None
Product: xorg
Classification: Unclassified
Component: Driver/Radeon (show other bugs)
Version: git
Hardware: x86 (IA32) Solaris
: high normal
Assignee: Xorg Project Team
QA Contact:
URL:
Whiteboard:
Keywords:
: 4103 (view as bug list)
Depends on:
Blocks: 1690
  Show dependency treegraph
 
Reported: 2005-08-06 11:43 UTC by Alan Coopersmith
Modified: 2005-10-10 18:11 UTC (History)
2 users (show)

See Also:
i915 platform:
i915 features:


Attachments
Patch to RADEONUpdatePanelSize in radeon_driver.c (617 bytes, patch)
2005-08-28 14:44 UTC, Alan Coopersmith
no flags Details | Splinter Review

Description Alan Coopersmith 2005-08-06 11:43:09 UTC
On an Acer Ferrari 4000 laptop with Radeon Mobility X700, it can't find the 
internal display unless you set 
    Option     "MonitorLayout" "LVDS,VGA"  
in xorg.conf.

Once you do that though, Xorg crashes in RADEONUpdatePanelSize() unless you
also set the PanelSize option because the  pScrn->monitor->DDC pointer is
NULL, but this code doesn't check it before dereferencing it.

Inserting a simple check to return on NULL allows it to continue and correctly
get the panel size from LVDS.

This has been seen both on current Xorg CVS head, 6.9RC0, and head plus the
29-Jul version of the Radeon superpatch from bug #3621.
Comment 1 Alan Coopersmith 2005-08-06 11:44:43 UTC
Created attachment 3275 [details]
Corrected cpp test file
Comment 2 Alan Coopersmith 2005-08-06 11:47:15 UTC
Created attachment 3276 [details]
public PGP key for kou@cozmixng.org
Comment 3 Alan Coopersmith 2005-08-06 11:55:36 UTC
Created attachment 3278 [details]
screenshot of openoffice2 under a broken xorg
Comment 4 Adam Jackson 2005-08-08 02:41:51 UTC
looks good.
Comment 5 Alan Coopersmith 2005-08-28 14:44:46 UTC
Created attachment 3094 [details] [review]
Patch to RADEONUpdatePanelSize in radeon_driver.c

Reattaching patch lost in bugzilla disk death.
Comment 6 T. Hood 2005-09-26 07:59:35 UTC
This patch has still not been applied.
Comment 7 T. Hood 2005-09-26 08:04:09 UTC
*** Bug 4103 has been marked as a duplicate of this bug. ***
Comment 8 Adam Jackson 2005-10-02 23:15:14 UTC
commited, as being freakin' obvious.  thanks!


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.