Bug 40405 - piglit vp-max-array regression
Summary: piglit vp-max-array regression
Status: CLOSED FIXED
Alias: None
Product: Mesa
Classification: Unclassified
Component: Mesa core (show other bugs)
Version: 7.11
Hardware: x86 (IA32) Linux (All)
: medium normal
Assignee: Brian Paul
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-08-26 12:44 UTC by Vinson Lee
Modified: 2011-09-14 13:49 UTC (History)
1 user (show)

See Also:
i915 platform:
i915 features:


Attachments

Description Vinson Lee 2011-08-26 12:44:15 UTC
piglit vp-max-array has regressed on softpipe and llvmpipe.

mesa: 3bcb9a858f482c21bc7c4d0fcd3571e25ea95090 (master) - fail
mesa: 6c1a9a327d031cd46680f28de8636b9335847650 (7.11) - fail
mesa: 7c3cf50d9988d721e79277180e29aaf6afa40be5 (7.10) - pass
mesa: 5078cb68586a52e2a2a991c6e89ed42e8bac7d96 (7.9) - pass


$ ./bin/vp-max-array -auto
Mesa: User error: GL_INVALID_OPERATION in glProgramStringARB(invalid local parameter reference)

Mesa: User error: GL_INVALID_OPERATION in glProgramString(bad program)
Compiler Error (pos=79 line=-1): line 3, char 41: error: invalid local parameter reference

ram.local[0..4095] }
in program:
!!ARBvp1.0
OPTION	ARB_position_invariant;
PARAM	colors[4096] = { program.local[0..4095] };

MOV	result.color, colors[0];
END
PIGLIT: {'result': 'fail' }
Comment 1 Vinson Lee 2011-08-26 13:17:17 UTC
f9cc6acbfa6f6f91b29a0601436d91a330fdce79 is the first bad commit
commit f9cc6acbfa6f6f91b29a0601436d91a330fdce79
Author: Brian Paul <brianp@vmware.com>
Date:   Wed Apr 27 09:31:30 2011 -0600

    st/mesa: raise shader MaxParameters if driver supports more
    
    The default value is 64 but drivers usually advertise more, like 4096.
    Allows ARB vp/fp programs to use more parameters.
    
    Reviewed-by: Jose Fonseca <jfonseca@vmware.com>

:040000 040000 812e681a5f4e6d7921f676d244b81ff79feeeb09 f18dfdba56466b0219c0ccd3d3139a059fa984ed M	src
bisect run success
Comment 2 Brian Paul 2011-08-30 10:20:24 UTC
Looks like this is actually a bug in the piglit test.  I've posted a patch for review to the piglit list.
Comment 3 Ian Romanick 2011-09-04 18:15:38 UTC
This should be fixed by the following piglit commit:

commit c19366f77895608bc4cd0e6b3bbc92b6b17f2c29
Author: Ian Romanick <ian.d.romanick@intel.com>
Date:   Tue Aug 30 11:05:41 2011 -0700

    vp-max-array: Exercise GL_MAX_PROGRAM_PARAMETERS_ARB with a contant array
    
    This eliminates the dependency on GL_MAX_PROGRAM_LOCAL_PARAMETERS_ARB.
    In particular, this makes the test run correctly on implementations
    where GL_MAX_PROGRAM_LOCAL_PARAMETERS_ARB is less than
    GL_MAX_PROGRAM_PARAMETERS_ARB.
    
    Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=40405
    Tested-by: Brian Paul <brianp@vmware.com>
Comment 4 Vinson Lee 2011-09-14 13:49:38 UTC
mesa: 00792e3586746c833ffc9bb65712e38038916e06 (master)
piglit: 59502051469ba3648a537cf694b910d5b72c8161 (master)

vp-max-array passes now.


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.