Bug 40412 - [softpipe] piglit ARB_color_buffer_float/GL_RGBA8-render-sanity-fog regression
Summary: [softpipe] piglit ARB_color_buffer_float/GL_RGBA8-render-sanity-fog regression
Status: CLOSED FIXED
Alias: None
Product: Mesa
Classification: Unclassified
Component: Other (show other bugs)
Version: 7.11
Hardware: x86 (IA32) Linux (All)
: medium normal
Assignee: Brian Paul
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-08-26 14:51 UTC by Vinson Lee
Modified: 2011-09-14 13:53 UTC (History)
1 user (show)

See Also:
i915 platform:
i915 features:


Attachments

Description Vinson Lee 2011-08-26 14:51:50 UTC
piglit ARB_color_buffer_float/GL_RGBA8-render-sanity-fog now fails with softpipe on master and 7.11. It passes with 7.10 and 7.9.

mesa: 3bcb9a858f482c21bc7c4d0fcd3571e25ea95090 (master) - fail
mesa: 6c1a9a327d031cd46680f28de8636b9335847650 (7.11) - fail
mesa: 7c3cf50d9988d721e79277180e29aaf6afa40be5 (7.10) - pass
mesa: 5078cb68586a52e2a2a991c6e89ed42e8bac7d96 (7.9) - pass

$ ./bin/arb_color_buffer_float-render GL_RGBA8 sanity fog
Testing 8-bit unsigned normalized fixed-point FBO
Testing default clamping rules only. This is a sanity check. GL_ARB_color_buffer_float is not required.
FAIL: un8: Attrib COLOR      VertClamp TRUE   FragClamp FIXED  Blending (CONST, ZERO)  LogicOp No   ffvp    fffp    Fog Yes (expecting clamping)
  Expected: 1.000000 0.000000 0.000000 0.750000
  Observed: 1.000000 0.000000 0.000000 1.000000
FAIL: un8: Attrib COLOR      VertClamp TRUE   FragClamp FIXED  Blending (CONST, ZERO)  LogicOp No   ARB_vp  fffp    Fog Yes (expecting clamping)
  Expected: 1.000000 0.000000 0.000000 0.750000
  Observed: 1.000000 0.000000 0.000000 1.000000
Summary: 46/48 passed.
PIGLIT: {'result': 'fail' }
Comment 1 Vinson Lee 2011-08-26 17:09:06 UTC
e5c6a92a12b5cd7db205d72039f58d302b0be9d5 is the first bad commit
commit e5c6a92a12b5cd7db205d72039f58d302b0be9d5
Author: Marek Olšák <maraeo@gmail.com>
Date:   Tue Feb 15 23:30:23 2011 +0100

    mesa: implement clamping controls (ARB_color_buffer_float)
    
    Squashed commit of the following:
    
    Author: Marek Olšák <maraeo@gmail.com>
    
        mesa: fix getteximage so that it doesn't clamp values
        mesa: update the compute_version function
        mesa: add display list support for ARB_color_buffer_float
        mesa: fix glGet query with GL_ALPHA_TEST_REF and ARB_color_buffer_float
    
    commit b2f6ddf907935b2594d2831ddab38cf57a1729ce
    Author: Luca Barbieri <luca@luca-barbieri.com>
    Date:   Tue Aug 31 16:50:57 2010 +0200
    
        mesa: document known possible deviations from ARB_color_buffer_float
    
    commit 5458935be800c1b19d1c9d1569dc4fa30a97e8b8
    Author: Luca Barbieri <luca@luca-barbieri.com>
    Date:   Tue Aug 24 21:54:56 2010 +0200
    
        mesa: expose GL_ARB_color_buffer_float
    
    commit aef5c3c6be6edd076e955e37c80905bc447f8a82
    Author: Luca Barbieri <luca@luca-barbieri.com>
    Date:   Thu Aug 26 18:12:34 2010 +0200
    
        mesa, mesa/st: handle read color clamping properly
    
        (I'll squash the st/mesa part to a separate commit. -Marek)
    
        We set IMAGE_CLAMP_BIT in the caller based on _ClampReadColor, where
        the operation mandates it.
    
        TODO: did I get the set of operations mandating it right?
    
    commit 3a9cb5e59b676b6148c50907ce6eef5441677e36
    Author: Luca Barbieri <luca@luca-barbieri.com>
    Date:   Thu Aug 26 18:09:41 2010 +0200
    
        mesa: respect color clamping in texenv programs (v2)
    
        Changes in v2:
        - Fix attributes other than vertex color sometimes getting clamped
    
    commit de26f9e47e886e176aab6e5a2c3d4481efb64362
    Author: Luca Barbieri <luca@luca-barbieri.com>
    Date:   Thu Aug 26 18:05:53 2010 +0200
    
        mesa: restore color clamps on glPopAttrib
    
    commit a55ac3c300c189616627c05d924c40a8b55bfafa
    Author: Luca Barbieri <luca@luca-barbieri.com>
    Date:   Thu Aug 26 18:04:26 2010 +0200
    
        mesa: clamp color queries if and only if fragment clamping is enabled
    
    commit 9940a3e31c2fb76cc3d28b15ea78dde369825107
    Author: Luca Barbieri <luca@luca-barbieri.com>
    Date:   Wed Aug 25 00:00:16 2010 +0200
    
        mesa: introduce derived _ClampXxxColor state resolving FIXED_ONLY
    
        To do this, we make ClampColor call FLUSH_VERTICES with the appropriate
        _NEW flag.
    
        We introduce _NEW_FRAG_CLAMP since fragment clamping has wide-ranging
        effects, despite being in the Color attrib group.
    
        This may be easily changed by s/_NEW_FRAG_CLAMP/_NEW_COLOR/g
    
    commit 6244c446e3beed5473b4e811d10787e4019f59d6
    Author: Luca Barbieri <luca@luca-barbieri.com>
    Date:   Thu Aug 26 17:58:24 2010 +0200
    
        mesa: add unclamped color parameters

:040000 040000 554e49f40d4d8635966eb010df6216d999621c88 216b4d3a590f8b3c6477db9eb815c98e3572d4e9 M	docs
:040000 040000 377f3c1595bba3f074ae5a78693bf6adfba1e18a 427894a2aca305426845e02807891a605fe957a2 M	src
bisect run success
Comment 2 Brian Paul 2011-09-14 07:17:07 UTC
Fixed with commit ec22b75be1c57f991f48bf6cc1d4b910911e8bf2
Comment 3 Vinson Lee 2011-09-14 13:53:29 UTC
mesa: 00792e3586746c833ffc9bb65712e38038916e06 (master)

Verified fixed.


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.