Bug 40441 - Some players require DOS folder seperators
Summary: Some players require DOS folder seperators
Status: RESOLVED FIXED
Alias: None
Product: media-player-info
Classification: Unclassified
Component: General (show other bugs)
Version: unspecified
Hardware: Other All
: medium enhancement
Assignee: Martin Pitt
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-08-28 14:20 UTC by William Witt
Modified: 2011-09-05 22:38 UTC (History)
0 users

See Also:
i915 platform:
i915 features:


Attachments

Description William Witt 2011-08-28 14:20:14 UTC
Some players, like the Sansa Fuze, require DOS folder separators. We need a way to capture this information.  While we are at it, some players might also require DOS or Mac line endings.

Recommend adding FolderSeperator and LineEnding properties to the [Playlist] section.
Comment 1 Martin Pitt 2011-08-29 03:05:50 UTC
Do any of the existing player applications (Rhythmbox, Banshee, Amarok, etc.) already support these fields? Is there a corresponding bug report for these?
Comment 2 William Witt 2011-08-29 05:01:31 UTC
Banshee has at least these two bug reports requesting this feature (gnome's bugzilla is down at the moment, or I'd look for more):
https://bugzilla.gnome.org/show_bug.cgi?id=587964
https://bugzilla.gnome.org/show_bug.cgi?id=609488

I've been doing some minor hacking on Banshee and would be more than willing to write a submit a patch for this feature.
Comment 3 Martin Pitt 2011-09-05 06:35:13 UTC
Definition of the properties:

http://cgit.freedesktop.org/media-player-info/commit/?id=b2ebb64c1d6797f7b9e8bda0cbbbe61484fb54a2

Fuze:
http://cgit.freedesktop.org/media-player-info/commit/?id=16d027f9687038f801ff2f6f62ad4f18523dc842

Does that look appropriate to you? If so, I'll make a new release this week.
Comment 4 William Witt 2011-09-05 12:11:06 UTC
I ran into an issue trying to read a "FolderSeparator=\" from a hand edited .mpi file.  Either it was confused because \ is the unicersal sign to continue on the next line, or because it was trying to escape the line feed. I could read "FolderSeparator=\\" just fine (but it in fact was decoded as "\\").  We might be better off with either "UNIX" or "DOS".
Comment 5 Martin Pitt 2011-09-05 22:38:31 UTC
Ah, that might depend on the implementation then indeed. I tried it with Python's ConfigParser, and it reads a single '\' just fine. But similarly to LineEnding we can just use symbolic names.

http://cgit.freedesktop.org/media-player-info/commit/?id=916cee7bb2664029e16633af4fac4915de28049c

This requires some more logic on the player side, but should be safe.


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.