Bug 40635 - Depend on relevant versions of alsa + dbus rather than support backwards compat via #ifdefs
Summary: Depend on relevant versions of alsa + dbus rather than support backwards comp...
Status: RESOLVED FIXED
Alias: None
Product: PulseAudio
Classification: Unclassified
Component: build-system (show other bugs)
Version: unspecified
Hardware: Other All
: medium normal
Assignee: Colin Guthrie
QA Contact: pulseaudio-bugs
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 40193
  Show dependency treegraph
 
Reported: 2011-09-05 02:22 UTC by Colin Guthrie
Modified: 2011-09-07 13:16 UTC (History)
2 users (show)

See Also:
i915 platform:
i915 features:


Attachments

Description Colin Guthrie 2011-09-05 02:22:57 UTC
We should not bother supporting the versions of alsa and dbus that don't give us what we want. So strip out the stuff that is dependant on this and just require the newer versions (i.e. kill off compat checks for DBUS_TYPE_UNIX_FD)
Comment 1 Colin Guthrie 2011-09-07 11:50:06 UTC
Assign to me to work on.
Comment 2 Maarten Bosmans 2011-09-07 12:46:01 UTC
The alsa version requirement would then be bumped to 1.0.24 (released 2011-01-31) from the current 1.0.19. I strongly oppose that dependency for pulse 1.0, even more so because we gain nothing substantial from not allowing older versions.
Comment 3 Colin Guthrie 2011-09-07 13:15:22 UTC
I agree on the alsa front. As you said on IRC, this is probably a problem for some folks that want to use 1.0, e.g. when installing on little embedded devices etc. No reason to really make things awkward. We'll kill off support for older alsa in six months or a year or so unless some other major change comes along to force it sooner.

I'm still in favour of generally increasing requirements to keep people up-to-date tho' :)
Comment 4 Colin Guthrie 2011-09-07 13:16:54 UTC
commit 69fe26206f9ce204db58c0cedd87a6063810c179
Author: Colin Guthrie <colin@mageia.org>
Date:   Wed Sep 7 20:19:44 2011 +0100

    bluetooth: Bump DBus version to 1.3.0 and drop conditional code.
    
    We used to support older DBus versions but 1.3.0 is two years old
    now and by requiring it we cut down of deviated code paths at
    runtime and thus have less support issues.
    
    fdo#40635


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.