Bug 40637 - module-loopback: Kill off some module arguments and make more generic
Summary: module-loopback: Kill off some module arguments and make more generic
Status: RESOLVED FIXED
Alias: None
Product: PulseAudio
Classification: Unclassified
Component: modules (show other bugs)
Version: unspecified
Hardware: Other All
: medium normal
Assignee: Tanu Kaskinen
QA Contact: pulseaudio-bugs
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 40193
  Show dependency tree / graph
 
Reported: 2011-09-05 02:38 UTC by Colin Guthrie
Modified: 2011-09-07 13:18 UTC (History)
2 users (show)

See Also:
i915 platform:
i915 features:

Attachments

Description Colin Guthrie 2011-09-05 02:38:07 UTC 
These arguments should be killed:

        "sink_input_name=<custom name for the sink input> "
        "source_output_name=<custom name for the source output> "
        "sink_input_role=<media.role for the sink input> "
        "source_output_role=<media.role for the source output> "


And replaced with sink_input_properties and source_output_properties which can handle both media.name and media.role properties that these specific args set.

The *_dont_move args are flags so have to stay as specific args. These were not in 0.9.23 so no issue with backwards compatibility.
Comment 1 Tanu Kaskinen 2011-09-05 09:49:59 UTC 
Assigning to myself.
Comment 2 Tanu Kaskinen 2011-09-06 10:34:52 UTC 
Fix sent to the mailing list: http://lists.freedesktop.org/archives/pulseaudio-discuss/2011-September/011225.html
Comment 3 Colin Guthrie 2011-09-07 11:48:40 UTC 
In my tree now! Many thanks!
Comment 4 Colin Guthrie 2011-09-07 13:18:03 UTC 
commit badc32adb9f338d7e33a01fd171b0aeb8e8c2ef2
Author: Tanu Kaskinen <tanuk@...>
Date:   Tue Sep 6 20:33:42 2011 +0300

    loopback: New modargs: sink_input_properties and source_output_properties.
    
    The new modargs replace sink_input_name, sink_input_role,
    source_output_name and source_output_role.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.