Bug 40883 - [GM965 bisected 3.0->3.1-rc1] Screen corruption unless i915.i915_enable_fbc=0
Summary: [GM965 bisected 3.0->3.1-rc1] Screen corruption unless i915.i915_enable_fbc=0
Status: CLOSED FIXED
Alias: None
Product: DRI
Classification: Unclassified
Component: DRM/Intel (show other bugs)
Version: unspecified
Hardware: x86-64 (AMD64) Linux (All)
: medium normal
Assignee: Chris Wilson
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-09-14 11:40 UTC by Jonathan Nieder
Modified: 2017-07-24 23:04 UTC (History)
7 users (show)

See Also:
i915 platform:
i915 features:


Attachments

Description Jonathan Nieder 2011-09-14 11:40:39 UTC
This report is to track a regression introduced between v3.0 and v3.1-rc1. Please don't close it until it has been fixed in mainline.

Submitter: Philipp Klaus Krause <pkk@spth.de>
Date: 2011-08-31 08:43:06 +0200
Message-ID: <4E5DD7FA.9000103@spth.de>
Reference: http://thread.gmane.org/gmane.comp.freedesktop.xorg.drivers.intel/5491
Reference: http://bugs.debian.org/641622
First-bad-commit: d74362c9e45689d8d7e3d4bcf6681c4358ef4f2e "drm/i915: Flush other plane register writes"

 In the free game simutrans, in fullscreen mode I see the following problem:
 The lower about 2 cm of the screen don't update. They are black or carry
 the image from the game startup screen. They flicker once in a while,
 but otherwise the image stays the same.
[...]
 Switching to the console and back or taking a screen shot is a temporary
 (few seconds) workaround.
 Using kernel command line i915.i915_enable_fbc=0 is a permanent workaround.
Comment 1 Gordon Jin 2011-09-14 18:16:43 UTC
The reported platform is GM965. Ouping, can you reproduce it?

The bisected commit:
commit d74362c9e45689d8d7e3d4bcf6681c4358ef4f2e
Author: Keith Packard <keithp@keithp.com>
Date:   Thu Jul 28 14:47:14 2011 -0700

    drm/i915: Flush other plane register writes

    Writes to the plane control register are buffered in the chip until a
    write to the DSPADDR (pre-965) or DSPSURF (post-965) register occurs.

    This patch adds flushes in:

    	intel_enable_plane
    	gen6_init_clock_gating
    	ivybridge_init_clock_gating

    Signed-off-by: Keith Packard <keithp@keithp.com>
Comment 2 Ouping Zhang 2011-09-15 23:07:27 UTC
with the same kernel, run game simutrans, but I can't reproduce the issue, could you please post the System Environment(include libdrm, mesa and Xserver commit). It seems that game simutrans use 2D driver. 
System Environment:
--------------------------
Kernel:     (drm-intel-next)d74362c9e45689d8d7e3d4bcf6681c4358ef4f2e
Libdrm:     (master)2.4.26-3-g2acaf160df584a5ef7b5c5b84819389948cd97ad
Mesa:       (master)00792e3586746c833ffc9bb65712e38038916e06
Xserver:    (master)xorg-server-1.11.0
(In reply to comment #0)
> This report is to track a regression introduced between v3.0 and v3.1-rc1.
> Please don't close it until it has been fixed in mainline.
> Submitter: Philipp Klaus Krause <pkk@spth.de>
> Date: 2011-08-31 08:43:06 +0200
> Message-ID: <4E5DD7FA.9000103@spth.de>
> Reference:
> http://thread.gmane.org/gmane.comp.freedesktop.xorg.drivers.intel/5491
> Reference: http://bugs.debian.org/641622
> First-bad-commit: d74362c9e45689d8d7e3d4bcf6681c4358ef4f2e "drm/i915: Flush
> other plane register writes"
>  In the free game simutrans, in fullscreen mode I see the following problem:
>  The lower about 2 cm of the screen don't update. They are black or carry
>  the image from the game startup screen. They flicker once in a while,
>  but otherwise the image stays the same.
> [...]
>  Switching to the console and back or taking a screen shot is a temporary
>  (few seconds) workaround.
>  Using kernel command line i915.i915_enable_fbc=0 is a permanent workaround.
Comment 3 Ouping Zhang 2011-09-18 18:10:30 UTC
what's more,i915.i915_enable_fbc=0 is default in kernel(commit: d74362c9e45689d8d7e3d4bcf6681c4358ef4f2e).so you didn't use kernel command line i915.i915_enable_fbc=0 in grub.
(In reply to comment #0)
> This report is to track a regression introduced between v3.0 and v3.1-rc1.
> Please don't close it until it has been fixed in mainline.
> Submitter: Philipp Klaus Krause <pkk@spth.de>
> Date: 2011-08-31 08:43:06 +0200
> Message-ID: <4E5DD7FA.9000103@spth.de>
> Reference:
> http://thread.gmane.org/gmane.comp.freedesktop.xorg.drivers.intel/5491
> Reference: http://bugs.debian.org/641622
> First-bad-commit: d74362c9e45689d8d7e3d4bcf6681c4358ef4f2e "drm/i915: Flush
> other plane register writes"
>  In the free game simutrans, in fullscreen mode I see the following problem:
>  The lower about 2 cm of the screen don't update. They are black or carry
>  the image from the game startup screen. They flicker once in a while,
>  but otherwise the image stays the same.
> [...]
>  Switching to the console and back or taking a screen shot is a temporary
>  (few seconds) workaround.
>  Using kernel command line i915.i915_enable_fbc=0 is a permanent workaround.
Comment 4 Chris Wilson 2011-09-30 12:55:21 UTC
FBC are now disabled again on Ironlake by default.
Comment 5 Chris Wilson 2011-09-30 12:55:36 UTC
(And pre-Ironlake!)


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.