Bug 4095 - Change DEFAULT_DRIVER_DIR for modular XOrg
Summary: Change DEFAULT_DRIVER_DIR for modular XOrg
Status: RESOLVED FIXED
Alias: None
Product: Mesa
Classification: Unclassified
Component: GLX (show other bugs)
Version: git
Hardware: x86 (IA32) Linux (All)
: high normal
Assignee: mesa-dev
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-08-14 19:25 UTC by Donnie Berkholz
Modified: 2009-08-24 12:23 UTC (History)
0 users

See Also:
i915 platform:
i915 features:


Attachments
change-default-dri-driver-dir.patch (412 bytes, patch)
2005-08-14 19:26 UTC, Donnie Berkholz
Details | Splinter Review
change-default-dri-driver-dir-2.patch (399 bytes, patch)
2005-08-19 13:37 UTC, Donnie Berkholz
Details | Splinter Review

Description Donnie Berkholz 2005-08-14 19:25:46 UTC
The default directory to look for DRI drivers is "/usr/X11R6/lib/modules/dri"
now. Since the monolithic XOrg build defines DEFAULT_DRIVER_DIR on the command
line, this can safely be changed to "/usr/lib/xorg/modules/dri" for a sensible
future default.
Comment 1 Donnie Berkholz 2005-08-14 19:26:28 UTC
Created attachment 2858 [details] [review]
change-default-dri-driver-dir.patch
Comment 2 Daniel Stone 2005-08-15 08:14:22 UTC
Um, why /usr/lib/xorg?  If anything, it should be /usr/lib/mesa.  I'm running
with /usr/lib/dri (no /modules/dri, just with the modules straight under
/usr/lib/dri) for the Ubuntu build of Mesa, at least for the time being.
Comment 3 Donnie Berkholz 2005-08-15 09:38:20 UTC
Because the dri modules have historically installed into the dri/ subdirectory
of where all the other X modules go. And they install to /usr/lib/xorg/modules.
Comment 4 Daniel Stone 2005-08-15 10:35:32 UTC
Sure, but libGL is no longer being provided by xorg; it's being provided by Mesa
in the modular world, which is a completely separate project to X.Org, and may
well be installed in a separate prefix.  $(xorg_prefix)/lib/xorg/modules
contains modules for the X.Org server; $(mesa_prefix)/lib/dri, presumably,
contains client-side modules for Mesa's libGL.
Comment 5 Donnie Berkholz 2005-08-15 10:41:31 UTC
You do have a point, but I think it will be confusing for people to have 2D
drivers in one place and 3D drivers somewhere completely different when they
used to be in the same place.
Comment 6 Michel Dänzer 2005-08-15 10:50:16 UTC
They used to be in the same place because the 3D drivers only worked in the X
environment. That's going to change with standalone EGL.
Comment 7 Donnie Berkholz 2005-08-15 10:59:58 UTC
OK then, let's change it to somewhere else. The one thing I can say is that
"/usr/X11R6/lib/modules/dri" isn't the right place. Daniel's suggestion of
/usr/lib/mesa/dri works for me.
Comment 8 Michel Dänzer 2005-08-16 08:42:44 UTC
I'm not sure it's a good idea for the path to contain 'mesa', as there could be
other drivers in there that don't have much if anything to do with Mesa. FWIW,
/usr/lib/dri sounds good to me.
Comment 9 Mike A. Harris 2005-08-19 13:34:34 UTC
Of the 3 locations (/usr/lib/xorg, /usr/lib/mesa, /usr/lib/dri), the
one Michel suggested seems to make the most sense to me.  Ultimately,
the DRI isn't X specific, so /usr/lib/dri seems to make the most
sense.

Comment 10 Donnie Berkholz 2005-08-19 13:37:29 UTC
Created attachment 2935 [details] [review]
change-default-dri-driver-dir-2.patch

K, /usr/lib/dri it is.
Comment 11 Søren Sandmann Pedersen 2005-08-19 13:44:46 UTC
I think this change should only be done in the modular build system, not in the
monolith. For the monolith we have generally not changed any of the default
paths, but we have done so in the modular tree.

The actual path should be configurable, so a new configure command line switch
will need to be added.
Comment 12 Donnie Berkholz 2005-08-19 13:51:01 UTC
The change is only visible in the modular build system, as I suggested in
comment #0, because the monolith passes -DDEFAULT_DRIVER_DIR as it compiles.

In addition, mesa is an external package from the monolith so it's difficult for
me to justify that it should be obeying everything XOrg does.

Perhaps mesa will at some point accept command-line switches, but for now you
could easily set DEFAULT_DRIVER_DIR as one of the defines in configs/.

But really this is about changing the default, not about all the ways to
configure it that could be added. It doesn't affect the monolith in any way I
can see, so I don't understand that argument.
Comment 13 Donnie Berkholz 2006-04-13 09:57:36 UTC
So why don't we change for 6.[56]?
Comment 14 Dan Nicholson 2009-05-31 10:31:13 UTC
This got fixed over a year ago after some mailing list discussion and is now ${libdir}/dri.

http://cgit.freedesktop.org/mesa/mesa/commit/?id=5dbbde5b
Comment 15 Adam Jackson 2009-08-24 12:23:21 UTC
Mass version move, cvs -> git


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.