Bug 41182 - X server does not check module version when reloading modules
Summary: X server does not check module version when reloading modules
Status: RESOLVED FIXED
Alias: None
Product: xorg
Classification: Unclassified
Component: Server/DDX/Xorg/dlloader (show other bugs)
Version: 7.6 (2010.12)
Hardware: Other All
: medium normal
Assignee: Adam Jackson
QA Contact: Xorg Project Team
URL:
Whiteboard: 2011BRB_Reviewed
Keywords:
Depends on:
Blocks:
 
Reported: 2011-09-25 05:10 UTC by Michal Suchanek
Modified: 2011-11-17 08:51 UTC (History)
0 users

See Also:
i915 platform:
i915 features:

Attachments
patch - check module version on every module load (4.73 KB, patch)
2011-09-25 05:10 UTC, Michal Suchanek 		no flags Details | Splinter Review
Show Obsolete (1) View All

Description Michal Suchanek 2011-09-25 05:10:07 UTC 
Created attachment 51585 [details] [review]
patch - check module version on every module load

The X server "duplicates" modules by loading them again from the disk.

Since this "duplication" happens on every input device hotplug, possibly weeks after the X server has been started a different module might have been installed by that time (eg. due to upgrading distribution packages) the X server should check the module every time it is loaded to prevent weird issues due to modules compiled for different ABI.

I compiled an X server with the patch and it worked but I have no idea how to test the error paths.
Comment 1 Jeremy Huddleston Sequoia 2011-10-06 12:24:38 UTC 
Please send your patch to xorg-devel for review.
Comment 2 Michal Suchanek 2011-11-17 08:51:55 UTC 
An alternative patch that prevents the reload was checked in.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.