Bug 41204 - Duplicate Name for Bengali keyboard layouts
Summary: Duplicate Name for Bengali keyboard layouts
Status: RESOLVED FIXED
Alias: None
Product: xkeyboard-config
Classification: Unclassified
Component: General (show other bugs)
Version: unspecified
Hardware: Other All
: medium normal
Assignee: xkb
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-09-25 21:05 UTC by Peter Hutterer
Modified: 2011-09-29 17:00 UTC (History)
0 users

See Also:
i915 platform:
i915 features:

Attachments
0001-rules-rename-Bengali-variants-for-in-to-Indian-Benga.patch (2.63 KB, patch)
2011-09-27 17:31 UTC, Peter Hutterer 		Details | Splinter Review
0001-rules-rename-Bengali-variants-for-in-to-Bengali-Indi.patch (2.63 KB, patch)
2011-09-29 16:13 UTC, Peter Hutterer 		Details | Splinter Review
Show Obsolete (1) View All

Description Peter Hutterer 2011-09-25 21:05:36 UTC 
Upstreamed from https://bugzilla.redhat.com/show_bug.cgi?id=740447


"IBus loads /usr/share/X11/xkb/rules/evdev.xml and there are duplicated
'Bengali' in evdev.xml.

    <layout>
      <configItem>
        <name>bd</name>
        <shortDescription>bn</shortDescription>
        <description>Bengali</description>
        <languageList>
          <iso639Id>ben</iso639Id>
        </languageList>
      </configItem>
...
...
    <layout>
      <configItem>
        <name>in</name>
        <shortDescription>in</shortDescription>
        <description>Indian</description>
      </configItem>
      <variantList>
        <variant>
          <configItem>
            <name>ben</name>
            <shortDescription>bn</shortDescription>
            <description>Bengali</description>
            <languageList>
              <iso639Id>ben</iso639Id>
            </languageList>
          </configItem>
        </variant>
        <variant>


I'd like to suggest to change the description in layout 'in' and variant 'ben'
to distinguish layout 'bd'."


Not sure what different name we could use here, the layouts are certainly different.
Comment 1 Sergey V. Udaltsov 2011-09-26 13:16:37 UTC 
Actually, there was no promise that descriptions are going to be unique. But you could come up with the good different names - we could discuss that.
Comment 2 Peter Hutterer 2011-09-27 17:31:11 UTC 
Created attachment 51695 [details] [review]
0001-rules-rename-Bengali-variants-for-in-to-Indian-Benga.patch

How about this one:

rules: rename Bengali variants for 'in' to Indian (Bengali)

This lines up the Bengali variants on the 'in' layout with other so that the use of the 'Bengali' description is unique to the 'bd' layout.
Comment 3 Sergey V. Udaltsov 2011-09-27 17:35:09 UTC 
Not quite like that. The format is typically "Language (Country)". So, "Bengali (India)" etc.
Comment 4 Peter Hutterer 2011-09-29 16:13:44 UTC 
Created attachment 51783 [details] [review]
0001-rules-rename-Bengali-variants-for-in-to-Bengali-Indi.patch

Updated patch, this time with Bengali (India, ...)
Comment 5 Sergey V. Udaltsov 2011-09-29 17:00:42 UTC 
Thanks, that is better. Except that you forgot to update symbols/in. Anyway, fixed and committed!

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.