Bugzilla – Bug 41216
[bisected pineview]oglc filtercubemin(basic.sizedRGBA) fails
Last modified: 2012-07-13 08:46:08 UTC
Bug detailed description:
It only happens on pineview. Below are cases failed due to the same commit.
Bisect find 980f6f1b37ca88529b3e000235156eab93254fac is the first bad commit.
Author: Brian Paul <email@example.com>
Date: Wed Sep 21 18:54:53 2011 -0600
mesa: move gl_texture_image::Width/Height/DepthScale fields to swrast
These fields were only used for swrast so move them into
Reviewed-by: Ian Romanick <firstname.lastname@example.org>
1. start X
2. ./oglconform -z -s -suite all -v 2 -D 115 -test filtercubemin basic.sizedRGBA
*** Bug 46196 has been marked as a duplicate of this bug. ***
I've sent a patch to the Piglit mailing list which addresses the following failures:
as well as the piglit test fbo/fbo-cubemap (bug 46196). I have not investigated the remaining failures.
The patch is:
Author: Paul Berry <email@example.com>
Date: Thu Feb 16 16:00:45 2012 -0800
i915: Initialize swrast_texture_image structure fields.
Commit 980f6f1 (mesa: move gl_texture_image::Width/Height/DepthScale
fields to swrast) moved the initialization of the Width, Height, and
DepthScale fields to _swrast_alloc_texture_image_buffer(). However,
i915 doesn't call this function because it performs its own buffer
allocation. As a result, the Width, Height, and DepthScale fields
weren't getting initialized properly, and some operations requiring
swrast would fail.
This patch ensures that Width, Height, and DepthScale are properly
initialized by separating the code that sets them into a new function,
_swrast_init_texture_image(), which is called by
intel_alloc_texture_image_buffer() as well as
_swrast_alloc_texture_image_buffer(). It also moves the
initialization of _IsPowerOfTwo into this function.
It passes on pineview now.
Verified with Mesa master commit 33202b4876a88b6f54ca7022eadd2875a2d3508a.