Bug 4128 - Linux/sparc needs hw/xfree86/os-support/xf86Sbus.h but it seems to be missing
Summary: Linux/sparc needs hw/xfree86/os-support/xf86Sbus.h but it seems to be missing
Status: RESOLVED FIXED
Alias: None
Product: xorg
Classification: Unclassified
Component: Build/Modular (show other bugs)
Version: 6.8.99.9
Hardware: SPARC Linux (All)
: high normal
Assignee: Xorg Project Team
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 5387
  Show dependency treegraph
 
Reported: 2005-08-17 10:53 UTC by Ferris McCormick
Modified: 2006-06-09 12:24 UTC (History)
2 users (show)

See Also:
i915 platform:
i915 features:


Attachments
The missing header file xf86Sbus.h (2.10 KB, text/plain)
2005-12-19 06:00 UTC, Ferris McCormick
no flags Details

Description Ferris McCormick 2005-08-17 10:53:18 UTC
ChangeLog date: Mon Aug  8 13:36:23 2005

In hw/xfree86/common/xf86Configure.c, we have:
=======================
#if defined(__sparc__) && !defined(__OpenBSD__)
#include "xf86Bus.h"
#include "xf86Sbus.h"
#endif
======================
However, the file xf86Sbus.h is not to be found:
======================
xf86Configure.c:56:22: xf86Sbus.h: No such file or directory
make[4]: *** [xf86Configure.o] Error 1
make[4]: *** Waiting for unfinished jobs....
======================
And a brute force find . -name xf86Sbus.h from the xorg-server root directory
confirms that there is no such file.  (os-support/bus/Sbus.c,
common/xf86sbusBus.c are there, as is xf86sbusBus.h, but no xf86Sbus.h).
Comment 1 Donnie Berkholz 2005-08-17 11:56:05 UTC
xf86Sbus.* aren't in the Makefile.am so they don't end up in the distributed
tarball.
Comment 2 Alan Coopersmith 2005-08-17 16:21:26 UTC
I've added xf86Sbus.h to EXTRA_DIST in
xserver/xorg/hw/xfree86/os-support/bus/Makefile.am so it should be included in
the next tarballs.   You can pull the file from CVS until then.
Comment 3 Ferris McCormick 2005-12-05 14:43:23 UTC
With xorg-server-0.99.4, xf86Sbus.h is missing again:  In
xorg-server-0.99.4/hw/xfree86/common, a make gives
=======================================
fer-de-lance common # make
make  all-am
make[1]: Entering directory
`/cache/tmp/portage/xorg-server-0.99.4/work/xorg-server-0.99.4/hw/xfree86/common'
if sparc-unknown-linux-gnu-gcc -DHAVE_CONFIG_H -I. -I. -I../../../include
-I../../../include -I../../../include -I../../../include -I../../../include
-I../../../include -I../../../hw/xfree86 -I../../../hw/xfree86/include
-I../../../hw/xfree86/common -I../../../hw/xfree86/os-support
-I../../../hw/xfree86/os-support/bus -I../../../os -I./../ddc -I./../i2c
-I./../loader -I./../rac -I./../parser -I./../scanpci -I./../vbe -I./../int10
-I./../vgahw -I./../dixmods/extmod   -DHAVE_XORG_CONFIG_H  -DXFree86Server 
-DXFree86LOADER -Wall -Wpointer-arith -Wstrict-prototypes -Wmissing-prototypes
-Wmissing-declarations -Wnested-externs -fno-strict-aliasing -D_BSD_SOURCE
-DHAS_FCHOWN -DHAS_STICKY_DIR_BIT   -I../../../include -I../../../include
-I../../../Xext -I../../../composite -I../../../damageext -I../../../xfixes
-I../../../Xi -I../../../mi -I../../../miext/shadow  -I../../../miext/damage
-I../../../render -I../../../randr -I../../../fb -I../../../lbx  
-mcpu=ultrasparc -O2 -mtune=ultrasparc -pipe -MT xf86Configure.o -MD -MP -MF
".deps/xf86Configure.Tpo" \
  -c -o xf86Configure.o `test -f 'xf86Configure.c' || echo './'`xf86Configure.c; \
then mv -f ".deps/xf86Configure.Tpo" ".deps/xf86Configure.Po"; \
else rm -f ".deps/xf86Configure.Tpo"; exit 1; \
fi
xf86Configure.c:56:22: xf86Sbus.h: No such file or directory
make[1]: *** [xf86Configure.o] Error 1
make[1]: Leaving directory
`/cache/tmp/portage/xorg-server-0.99.4/work/xorg-server-0.99.4/hw/xfree86/common'
make: *** [all] Error 2
====================================
And indeed, it's nowhere to be found in xorg-server-0.99.4/...
Comment 4 Ferris McCormick 2005-12-19 04:05:03 UTC
Still missing with xorg-server-1.0.0, which is annoying:  You can't build for
sparc without this little header file, and it just got dropped someplace. 
Please put it back.
Comment 5 Ferris McCormick 2005-12-19 06:00:41 UTC
Created attachment 4125 [details]
The missing header file xf86Sbus.h

The missing header file, in case anyone trying to build this need it but
doesn't have a copy lying around.
Comment 6 Adam Jackson 2006-03-01 05:13:19 UTC
appears to be present in the upcoming 1.0.2, closing.
Comment 7 Donnie Berkholz 2006-03-01 06:32:07 UTC
The 1.0 branch appears to be missing the commit, still. It's after the branch
point --
http://cvsweb.freedesktop.org/xorg/xserver/xorg/hw/xfree86/os-support/bus/Makefile.am?r1=1.16&r2=1.17
Comment 8 Donnie Berkholz 2006-06-09 12:24:52 UTC
Fixed in 1.1, at least, maybe earlier.


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.