Bug 41372 - i830_state.c PBO crash
Summary: i830_state.c PBO crash
Alias: None
Product: Mesa
Classification: Unclassified
Component: Drivers/DRI/i915 (show other bugs)
Version: unspecified
Hardware: Other All
: medium normal
Assignee: Ian Romanick
QA Contact:
Depends on:
Reported: 2011-09-30 15:17 UTC by Kurt Roeckx
Modified: 2012-03-02 18:31 UTC (History)
0 users

See Also:
i915 platform:
i915 features:

i830_state.c:i830PolygonStipple(): Make polygon stipple use pre-unpacked pixel data. (917 bytes, patch)
2011-09-30 15:17 UTC, Kurt Roeckx
Details | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Kurt Roeckx 2011-09-30 15:17:41 UTC
Created attachment 51814 [details] [review]
i830_state.c:i830PolygonStipple(): Make polygon stipple use pre-unpacked pixel data.


The glean pbo tests crashes in case it gets a NULL pattern.  The attached patch does the same thing in i830_state.c as this one does for i915_state.c:
commit a856da63247a4b403f6350914f732e14d1530ed1
Author: Eric Anholt <eric@anholt.net>
Date:   Tue Dec 18 14:14:44 2007 -0800

    [915] Make polygon stipple use pre-unpacked pixel data.
    This fixes a crash when stippling using data from a PBO.
Comment 1 Eric Anholt 2012-03-02 18:31:20 UTC
Pushed your fix.  Thanks!

commit 489ac8e73a2432d29597a62cd83f09b9d1848533
Author: Kurt Roeckx <kurt@roeckx.be>
Date:   Fri Mar 2 17:31:23 2012 -0800

    i915: Fix i830 polygon stipple from PBOs.
    This is a direct port of the i915 patch in
    Fixes glean's pbo test.
    Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=41372
    Reviewed-by: Eric Anholt <eric@anholt.net>
    NOTE: This is a candidate for release branches.

(note: in the future, git format-patch -1 will produce your git commit formatted in a way that's nice and easy to apply)

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct.