Bug 41388 - Should not assume password auth is supported
Summary: Should not assume password auth is supported
Status: RESOLVED FIXED
Alias: None
Product: Telepathy
Classification: Unclassified
Component: gabble (show other bugs)
Version: unspecified
Hardware: Other All
: medium normal
Assignee: Telepathy bugs list
QA Contact: Telepathy bugs list
URL: http://cgit.collabora.com/git/user/xc...
Whiteboard:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2011-10-01 11:43 UTC by Xavier Claessens
Modified: 2011-10-12 07:28 UTC (History)
0 users

See Also:
i915 platform:
i915 features:

Attachments

Description Xavier Claessens 2011-10-01 11:43:40 UTC 
Gabble always adds X-TELEPATHY-PASSWORD auth mechanism but not all services supports that. For example messenger.live.com can only auth via an access-token.

Wocky branch to add needed API:
http://cgit.collabora.com/git/user/xclaesse/wocky.git/log/?h=auth

Gabble branch to fix the bug:
http://cgit.collabora.com/git/user/xclaesse/telepathy-gabble.git/log/?h=auth
Comment 1 Will Thompson 2011-10-03 02:46:15 UTC 
I don't like the name of the method: it's singular, but the argument is plural.

How about wocky_auth_registry_supports_one_of()? (Which I don't like much either.)

And can we have a gtk-doc comment?

And the method implementation is wrong. I can see other password-based authentication mechanisms that Wocky supports; SCRAM-SHA-1, for starters. I think you probably want to be using some of the logic from wocky_auth_registry_select_handler() and/or wocky_auth_registry_start_auth_async_func().

Can you describe in the Gabble commit message why this is needed?
Comment 2 Xavier Claessens 2011-10-03 07:51:05 UTC 
branches updated
Comment 3 Will Thompson 2011-10-12 07:28:54 UTC 
Merged, will be in Gabble 0.13.7.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.