Bug 41392 - Incorrect specification for ChangeKeyboardMapping request
Summary: Incorrect specification for ChangeKeyboardMapping request
Status: RESOLVED FIXED
Alias: None
Product: XCB
Classification: Unclassified
Component: Protocol (show other bugs)
Version: unspecified
Hardware: All All
: high major
Assignee: xcb mailing list dummy
QA Contact: xcb mailing list dummy
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-10-01 16:18 UTC by Alex Plotnick
Modified: 2011-10-03 08:26 UTC (History)
1 user (show)

See Also:
i915 platform:
i915 features:

Attachments
Add missing padding bytes to ChangeKeyboardMapping request (453 bytes, patch)
2011-10-01 16:18 UTC, Alex Plotnick 		Details | Splinter Review
View All

Description Alex Plotnick 2011-10-01 16:18:14 UTC 
Created attachment 51860 [details] [review]
Add missing padding bytes to ChangeKeyboardMapping request

The ChangeKeyboardMapping request description in xproto.xml is wrong. There should be 2 padding bytes between the keysyms_per_keycode field and the keysyms list.
Comment 1 Peter Harris 2011-10-03 08:26:45 UTC 
Thanks for the patch. Pushed as dcfcb5845caca87df8b1ab735f05a801e43f5797

We probably didn't notice before now because the old libxcb did implicit padding differently.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.