Bug 41414 - tp_connection_upgrade_contacts() is not no-op if contacts are already prepared
Summary: tp_connection_upgrade_contacts() is not no-op if contacts are already prepared
Status: RESOLVED FIXED
Alias: None
Product: Telepathy
Classification: Unclassified
Component: tp-glib (show other bugs)
Version: unspecified
Hardware: Other All
: medium normal
Assignee: Telepathy bugs list
QA Contact: Telepathy bugs list
URL: http://cgit.collabora.com/git/user/xc...
Whiteboard: review+ modulo adding g_test_bug()
Keywords: patch
Depends on:
Blocks:
 
Reported: 2011-10-03 02:42 UTC by Xavier Claessens
Modified: 2011-10-04 10:31 UTC (History)
0 users

See Also:
i915 platform:
i915 features:

Attachments

Description Xavier Claessens 2011-10-03 02:42:23 UTC 
_contacts_by_handle() does strip out features that are already prepared on all contacts. The other paths should do as well.
Comment 1 Xavier Claessens 2011-10-03 04:39:34 UTC 
Here is patch for tp_connection_upgrade_contacts().

http://cgit.collabora.com/git/user/xclaesse/telepathy-glib.git/log/?h=no-op
Comment 2 Will Thompson 2011-10-03 16:01:15 UTC 
+/* Regression test case for fd.o#41414 */
+static void
+test_upgrade_noop (Fixture *f,
+    gconstpointer unused G_GNUC_UNUSED)

Use

  g_test_bug ("41414");

Otherwise looks great.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.