Bug 41621 - Reword lv3:*_switch_latch and lv5:*_switch_lock_cancel descriptions
Summary: Reword lv3:*_switch_latch and lv5:*_switch_lock_cancel descriptions
Status: RESOLVED FIXED
Alias: None
Product: xkeyboard-config
Classification: Unclassified
Component: General (show other bugs)
Version: unspecified
Hardware: Other All
: medium normal
Assignee: xkb
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-10-09 09:40 UTC by Rimas Kudelis
Modified: 2013-04-01 23:39 UTC (History)
0 users

See Also:
i915 platform:
i915 features:


Attachments
"acts as onetime lock" patch (3.99 KB, patch)
2011-10-09 09:40 UTC, Rimas Kudelis
Details | Splinter Review
"delays" patch (3.87 KB, patch)
2011-10-09 09:40 UTC, Rimas Kudelis
Details | Splinter Review

Description Rimas Kudelis 2011-10-09 09:40:13 UTC
Created attachment 52146 [details] [review]
"acts as onetime lock" patch

These options (why are they named differently, btw?) allow to delay level switch action when two same level choosers are pressed simultaniously.

However, their descriptions are inconsistent with each other, and the term "latching" is unclear.

The two patches attached reword those options to be consistent. First patch makes them sound like this:

KEYNAME chooses 3rd level, acts as onetime lock when pressed together with another 3rd-level-chooser

the second one rewords them like this:

KEYNAME chooses 3rd level, delays when pressed together with another 3rd-level-chooser

Choose one. :)
Comment 1 Rimas Kudelis 2011-10-09 09:40:47 UTC
Created attachment 52147 [details] [review]
"delays" patch
Comment 2 Rimas Kudelis 2011-10-09 09:48:01 UTC
NB: It looks like lv5:*_switch_lock_cancel options are actually nonfunctional, cause their descriptions look very much the same as lv5:*_switch_lock (without _cancel). Is this a bug?
Comment 3 Rimas Kudelis 2011-10-09 09:48:59 UTC
s/descriptions/definitions/ in last comment
Comment 4 Sergey V. Udaltsov 2011-10-09 10:43:41 UTC
*_switch_lock_cancel are using different xkb_type. Which is commented out because of the bug in XKB code. But at some point they will be enabled. I hope.
Comment 5 Sergey V. Udaltsov 2011-10-09 14:57:22 UTC
Regarding the bug in XKB code, affecting *_switch_lock_cancel, see bug #27988

Otherwise - committed, thanks!
Comment 6 Rimas Kudelis 2011-10-11 11:51:29 UTC
Since the lv5:*_switch_lock_cancel don't work yet (nothing to break thus), wouldn't it make sense to rename them to lv5:*_switch_latch for the sake of consistency?
Comment 7 Sergey V. Udaltsov 2011-10-14 14:32:56 UTC
I am not sure... perhaps hiding them altogether from base.xml.in would be more sane option
Comment 8 Rimas Kudelis 2011-10-15 01:46:14 UTC
(In reply to comment #7)
> I am not sure... perhaps hiding them altogether from base.xml.in would be more
> sane option

That makes sense for sure, please do so. I was simply suggesting to rename those options BEFORE bug #27988 is fixed.
Comment 9 Sergey V. Udaltsov 2011-10-17 13:07:24 UTC
ok, commented them out for now


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.