Bug 41823 - some pulseaudio modules use data type that conflicts with a system data type
Summary: some pulseaudio modules use data type that conflicts with a system data type
Status: RESOLVED FIXED
Alias: None
Product: PulseAudio
Classification: Unclassified
Component: modules (show other bugs)
Version: unspecified
Hardware: Other Solaris
: medium normal
Assignee: pulseaudio-bugs
QA Contact: pulseaudio-bugs
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-10-15 13:40 UTC by Brian Cameron
Modified: 2015-07-29 03:18 UTC (History)
3 users (show)

See Also:
i915 platform:
i915 features:

Attachments
Patch fixing issue (2.34 KB, patch)
2011-10-15 13:40 UTC, Brian Cameron 		Details | Splinter Review
Updated patch for PulseAudio 6.0 (2.78 KB, patch)
2015-07-28 20:52 UTC, shawn.walker@oracle.com 		Details | Splinter Review
Show Obsolete (1) View All

Description Brian Cameron 2011-10-15 13:40:16 UTC 
Created attachment 52368 [details] [review]
Patch fixing issue

The PulseAudio 1.0 GConf module fails to compile on Solaris because the /usr/include/sys/stream.h header also defines the module_info structure.  Is it possible to change the name of this to something more clearly PulseAudio specific, as shown in the attached patch?
Comment 1 Brian Cameron 2011-10-15 14:21:32 UTC 
Note that on Solaris, sys/types.h ends up including sys/stream.h
Comment 2 shawn.walker@oracle.com 2015-07-28 20:52:31 UTC 
Created attachment 117427 [details] [review]
Updated patch for PulseAudio 6.0
Comment 3 Arun Raghavan 2015-07-29 02:49:37 UTC 
I've merged this now. Would be nice to have git format-patches in the future, if possible,
Comment 4 shawn.walker@oracle.com 2015-07-29 03:18:52 UTC 
Thanks for merging the patch; I wasn't using git, so couldn't have provided a git formatted patch.  However, in the future, I'll try to use git instead.  Thanks again.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.