Bug 4202 - Connector detection code incorrect on x86
Summary: Connector detection code incorrect on x86
Status: RESOLVED FIXED
Alias: None
Product: xorg
Classification: Unclassified
Component: Driver/Radeon (show other bugs)
Version: git
Hardware: Other Linux (All)
: high normal
Assignee: Xorg Project Team
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 1690
  Show dependency treegraph
 
Reported: 2005-08-22 20:05 UTC by Benjamin Herrenschmidt
Modified: 2005-08-25 02:12 UTC (History)
1 user (show)

See Also:
i915 platform:
i915 features:


Attachments
Fix loop exit condition (563 bytes, patch)
2005-08-22 20:06 UTC, Benjamin Herrenschmidt
no flags Details | Splinter Review

Description Benjamin Herrenschmidt 2005-08-22 20:05:27 UTC
The radeon driver has a bug in the code parsing the connector table from the
BIOS, causing it to usually only ever get the infos for the first connector.
This is due to an incorrect loop exit condition. The attached patch fixes this
the simple way. That parsing code is still a bit dodgy as the connector table
can potentially get more complicated than a single list according to the spec,
but I've never seen that case happening in practice.
This should fix DVI detection in some cases
Comment 1 Benjamin Herrenschmidt 2005-08-22 20:06:18 UTC
Created attachment 3000 [details] [review]
Fix loop exit condition
Comment 2 Alex Deucher 2005-08-23 09:06:56 UTC
might as well get this in.  I'll test and commit soon unless some one beats me
to it.
Comment 3 Alex Deucher 2005-08-25 19:12:48 UTC
fixed in cvs.


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.