Created attachment 52754 [details] [review] Replace deprecated g_unix_socket_* functions I just tried building telepathy-glib git master from jhbuild and it failed due to deprecated functions (and the fact that -Werror=deprecated-declarations kicked them up to errors): gnio-util.c: In function 'tp_g_socket_address_from_variant': gnio-util.c:120:13: error: 'g_unix_socket_address_new_abstract' is deprecated (declared at /opt/gnome/include/gio-unix-2.0/gio/gunixsocketaddress.h:60): Use 'g_unix_socket_address_new_with_type' instead [-Werror=deprecated-declarations] gnio-util.c: In function 'tp_address_variant_from_g_socket_address': gnio-util.c:210:13: error: 'g_unix_socket_address_get_is_abstract' is deprecated (declared at /opt/gnome/include/gio-unix-2.0/gio/gunixsocketaddress.h:71) [-Werror=deprecated-declarations] cc1: all warnings being treated as errors
Comment on attachment 52754 [details] [review] Replace deprecated g_unix_socket_* functions Review of attachment 52754 [details] [review]: ----------------------------------------------------------------- Looks good except for a style point. ::: telepathy-glib/gnio-util.c @@ +213,2 @@ > type = TP_SOCKET_ADDRESS_TYPE_ABSTRACT_UNIX; > + } If you're going to add {} around one branch of the conditional, you should add them around the other, too.
http://cgit.freedesktop.org/telepathy/telepathy-glib/commit/?id=9a7d9195dab1035ffe2da0d7cd28c4a06b484881
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.