Bug 42296 - tp-glib creates insufficient binding for ContactInfoField with old versions of Vala
Summary: tp-glib creates insufficient binding for ContactInfoField with old versions o...
Status: RESOLVED FIXED
Alias: None
Product: Telepathy
Classification: Unclassified
Component: tp-glib (show other bugs)
Version: git master
Hardware: Other All
: medium normal
Assignee: Telepathy bugs list
QA Contact: Telepathy bugs list
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-10-26 17:08 UTC by Travis Reitter
Modified: 2011-11-11 10:56 UTC (History)
1 user (show)

See Also:
i915 platform:
i915 features:

Attachments
Bump Vala requirement (890 bytes, patch)
2011-10-26 17:08 UTC, Travis Reitter 		Details | Splinter Review
View All

Description Travis Reitter 2011-10-26 17:08:08 UTC 
Created attachment 52809 [details] [review]
Bump Vala requirement

If tp-glib is built with valac-0.12, it doesn't generate a Vala binding for the ContactInfoField constructor.

Folks depends upon this constructor, so building tp-glib with valac-0.12 and later Folks with valac-0.14 (or later) results in the following build failure (caught by Laurent):

VALAC  libfolks_telepathy_la_vala.stamp
tpf-persona-store.vala:2196.19-2196.67: error: `TelepathyGLib.ContactInfoField' does not have a default constructor
var field = new ContactInfoField ("bday", parameters, values);
            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

Once this fix is included in a release of tp-glib, Folks will depend upon that version.

(Vala 0.14.0 is the stable version for Gnome 3.2 and is included in the latest releases of the major distros).
Comment 1 Will Thompson 2011-11-11 10:56:21 UTC 
Merged to 0.16 and master!

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.