Bug 42305 - group-mixin: should set Members_Changed_Detailed flag
Summary: group-mixin: should set Members_Changed_Detailed flag
Status: RESOLVED FIXED
Alias: None
Product: Telepathy
Classification: Unclassified
Component: tp-glib (show other bugs)
Version: unspecified
Hardware: Other All
: medium normal
Assignee: Telepathy bugs list
QA Contact: Telepathy bugs list
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-10-27 03:13 UTC by Guillaume Desmottes
Modified: 2011-10-31 07:52 UTC (History)
0 users

See Also:
i915 platform:
i915 features:

Attachments
group-mixin: always set the Members_Changed_Detailed flag (2.08 KB, patch)
2011-10-27 03:32 UTC, Guillaume Desmottes 		Details | Splinter Review
View All

Description Guillaume Desmottes 2011-10-27 03:13:39 UTC 
The group mixin unconditionally implements MembersChangedDetailed so it should set the Members_Changed_Detailed as well.
Comment 1 Guillaume Desmottes 2011-10-27 03:32:23 UTC 
Created attachment 52819 [details] [review]
group-mixin: always set the Members_Changed_Detailed flag

We unconditionally implements the MembersChangedDetailed signal so this flag
should always be set.
Comment 2 Will Thompson 2011-10-28 10:51:11 UTC 
Comment on attachment 52819 [details] [review]
group-mixin: always set the Members_Changed_Detailed flag

Review of attachment 52819 [details] [review]:
-----------------------------------------------------------------

I think there was a reason I didn't do this but I can't figure out what it would be. So this looks good.
Comment 3 Guillaume Desmottes 2011-10-31 07:52:57 UTC 
Merged; will be in 0.16.2

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.