This is just like bug #42288 but for Salut. The proto-XEP doesn't really apply here because it doesn't use SI file transfers, it uses XEP-0066. Oh well. The implementation should be pretty much line-for-line the same as Gabble, so if you review one of them then the other is basically exactly the same. Go go power rangers!
In add_metadata_forms: + else + { + list = g_list_append (list, form); + } Is this in the Gabble branch too? Use a GQueue. I guess I got distracted by the yucky tree building. The rest looks very familiar. I guess some of my review comments from the Gabble bug may also apply here?
(In reply to comment #1) > In add_metadata_forms: > > + else > + { > + list = g_list_append (list, form); > + } > > Is this in the Gabble branch too? Use a GQueue. I guess I got distracted by the > yucky tree building. Fixed! It's not in Gabble. > The rest looks very familiar. I guess some of my review comments from the > Gabble bug may also apply here? Yes, I have cherry-picked the appropriate ones, which are most of them.
Looks good—though if i were to nitpick i'd point out that the FT.I.Metadata tests don't try specifying more than one value for a key.
Merged, thanks.
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.