Bug 42588 - pixman configure use non POSIX test
Summary: pixman configure use non POSIX test
Status: RESOLVED FIXED
Alias: None
Product: pixman
Classification: Unclassified
Component: pixman (show other bugs)
Version: other
Hardware: Other All
: medium normal
Assignee: Søren Sandmann Pedersen
QA Contact: Søren Sandmann Pedersen
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-11-04 05:11 UTC by naota@gentoo.org
Modified: 2011-11-24 05:37 UTC (History)
0 users

See Also:
i915 platform:
i915 features:

Attachments

Description naota@gentoo.org 2011-11-04 05:11:00 UTC 
pixman configure.ac file has the following line which is a non POSIX test construction.

   test "$test_CFLAGS" == "" &&         \

Please fix the line to work on POSIX shells like

   test "z$test_CFLAGS" = "z" &&         \

or such.
Comment 1 Søren Sandmann Pedersen 2011-11-08 09:38:57 UTC 
Thanks for the bug report. If you happen to have a patch for this, please consider sending it to pixman@lists.freedesktop.org.

I don't really want to blindly make changes here that I can't test myself.
Comment 2 Andrea Canciani 2011-11-24 05:37:47 UTC 
Pushed:

commit 84450c411cc93309bb1d1b1f555640b3ad105500
Author: Naohiro Aota <naota@gentoo.org>
Date:   Thu Nov 24 13:12:15 2011 +0100

    Don't use non-POSIX test
    
    test "$test_CFLAGS" == "" &&         \
    
    may cause an error on some POSIX shells and uses a style which is not
    consistent with the other tests in configure.ac
    
    Fixes https://bugs.freedesktop.org/show_bug.cgi?id=42588 and
    https://bugs.gentoo.org/show_bug.cgi?id=387087

Thank you!

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.