Bug 42652 - Subject interface needs to define more unknowns for properties
Summary: Subject interface needs to define more unknowns for properties
Status: RESOLVED FIXED
Alias: None
Product: Telepathy
Classification: Unclassified
Component: tp-spec (show other bugs)
Version: git master
Hardware: Other All
: medium normal
Assignee: Telepathy bugs list
QA Contact: Telepathy bugs list
URL: http://cgit.collabora.com/git/user/da...
Whiteboard:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2011-11-06 21:04 UTC by Danielle Madeley
Modified: 2011-11-07 02:58 UTC (History)
0 users

See Also:
i915 platform:
i915 features:

Attachments
Chan.I.Subject: add values for when properties are unknown (1.53 KB, patch)
2011-11-06 21:12 UTC, Danielle Madeley 		Details | Splinter Review
Chan.I.Subject: remove a white lie (1.06 KB, patch)
2011-11-06 21:27 UTC, Danielle Madeley 		Details | Splinter Review
Make unknown timestamp a G_MAXINT64 (2.81 KB, patch)
2011-11-07 02:29 UTC, Danielle Madeley 		Details | Splinter Review
Return the appropriate value in the case of an unknown timestamp (1.90 KB, patch)
2011-11-07 02:45 UTC, Danielle Madeley 		Details | Splinter Review
wocky-muc: return NULL if a timestamp can't be determined (928 bytes, patch)
2011-11-07 02:45 UTC, Danielle Madeley 		Details | Splinter Review
View All

Description Danielle Madeley 2011-11-06 21:04:17 UTC 
ActorHandle and Timestamp don't define values for when they are unknown.
Comment 1 Danielle Madeley 2011-11-06 21:12:25 UTC 
Created attachment 53227 [details] [review]
Chan.I.Subject: add values for when properties are unknown

Specifically ActorHandle and Timestamp.
Comment 3 Danielle Madeley 2011-11-06 21:27:28 UTC 
Created attachment 53228 [details] [review]
Chan.I.Subject: remove a white lie

Skype does not permit subjects on 1:1 chats. However, XMPP does, e.g. GMail
will include a 'subject' node when you click "Reply to Will by chat".
Comment 4 Will Thompson 2011-11-07 01:25:37 UTC 
Comment on attachment 53227 [details] [review]
Chan.I.Subject: add values for when properties are unknown

Review of attachment 53227 [details] [review]:
-----------------------------------------------------------------

::: spec/Channel_Interface_Subject.xml
@@ +95,4 @@
>                type="x" tp:type="Unix_Timestamp64" access="read">
>        <tp:docstring xmlns="http://www.w3.org/1999/xhtml">
>          <p>A unix timestamp indicating when the subject was last
> +         modified, or <code>INT_MAX64</code> if unknown.</p>

Okay, provided Gabble and Idle are updated to respect this. (They both use 0, explicitly and implicitly, respectively.)
Comment 5 Will Thompson 2011-11-07 01:26:07 UTC 
Comment on attachment 53228 [details] [review]
Chan.I.Subject: remove a white lie

Review of attachment 53228 [details] [review]:
-----------------------------------------------------------------

Looks good.
Comment 6 Danielle Madeley 2011-11-07 01:33:17 UTC 
Merged.

Patches for gabble and idle to follow.
Comment 7 Danielle Madeley 2011-11-07 02:29:19 UTC 
Created attachment 53236 [details] [review]
Make unknown timestamp a G_MAXINT64

This makes idle compliant with the updated spec.
Comment 8 Will Thompson 2011-11-07 02:36:21 UTC 
Comment on attachment 53236 [details] [review]
Make unknown timestamp a G_MAXINT64

Review of attachment 53236 [details] [review]:
-----------------------------------------------------------------

yarr.
Comment 9 Danielle Madeley 2011-11-07 02:45:50 UTC 
Created attachment 53238 [details] [review]
Return the appropriate value in the case of an unknown timestamp

This updates Gabble for the latest spec.

Fixes:
Comment 10 Danielle Madeley 2011-11-07 02:45:59 UTC 
Created attachment 53239 [details] [review]
wocky-muc: return NULL if a timestamp can't be determined

Fixes:
Comment 11 Will Thompson 2011-11-07 02:47:20 UTC 
The Gabble and Wocky bugs look good, too.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.