Bug 42811 - shell-test doesn't need --enable-embedded-tests and could be installed
Summary: shell-test doesn't need --enable-embedded-tests and could be installed
Status: RESOLVED FIXED
Alias: None
Product: dbus
Classification: Unclassified
Component: core (show other bugs)
Version: 1.4.x
Hardware: Other All
: medium enhancement
Assignee: Simon McVittie
QA Contact: John (J5) Palmieri
URL: http://cgit.freedesktop.org/~smcv/dbu...
Whiteboard:
Keywords: patch
Depends on:
Blocks: dbus-1.4
  Show dependency treegraph
 
Reported: 2011-11-11 03:29 UTC by Simon McVittie
Modified: 2012-02-21 07:19 UTC (History)
1 user (show)

See Also:
i915 platform:
i915 features:


Attachments
[1/2] Allow a reduced set of installable tests (none yet) to be built without GLib (3.56 KB, patch)
2011-11-11 03:31 UTC, Simon McVittie
Details | Splinter Review
[2/2] Mark shell-test as modular and installable (1.66 KB, patch)
2011-11-11 03:32 UTC, Simon McVittie
Details | Splinter Review

Description Simon McVittie 2011-11-11 03:29:44 UTC
test/shell-test needs internal libdbus API, but doesn't need --enable-embedded-tests, so we could treat it like the modular tests and even make it installable. Better test coverage in distro versions of dbus? Yes please.
Comment 1 Simon McVittie 2011-11-11 03:31:12 UTC
Created attachment 53395 [details] [review]
[1/2] Allow a reduced set of installable tests (none yet) to  be built without GLib

--enable-modular-tests=auto will build as many as possible, perhaps
excluding the GLib ones. --enable-modular-tests=yes or --enable-tests=yes
will insist on having GLib, to be able to run everything.
Comment 2 Simon McVittie 2011-11-11 03:32:02 UTC
Created attachment 53396 [details] [review]
[2/2] Mark shell-test as modular and installable

This test needs non-public API and so is statically linked, but is OK
to install.
Comment 3 Simon McVittie 2012-02-08 09:45:24 UTC
ssh://people.freedesktop.org/~smcv/dbus.git 14-shell-test-42811
Comment 4 Guillaume Desmottes 2012-02-20 05:20:55 UTC
Comment on attachment 53395 [details] [review]
[1/2] Allow a reduced set of installable tests (none yet) to  be built without GLib

Review of attachment 53395 [details] [review]:
-----------------------------------------------------------------

++
Comment 5 Guillaume Desmottes 2012-02-20 05:21:27 UTC
Comment on attachment 53396 [details] [review]
[2/2] Mark shell-test as modular and installable

Review of attachment 53396 [details] [review]:
-----------------------------------------------------------------

I'm gonna trust your word on this.
Comment 6 Simon McVittie 2012-02-21 07:19:26 UTC
Thanks, merged for 1.5.10.


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.