Bug 42834 - [softpipe] piglit draw-instanced regression
Summary: [softpipe] piglit draw-instanced regression
Status: CLOSED FIXED
Alias: None
Product: Mesa
Classification: Unclassified
Component: Other (show other bugs)
Version: unspecified
Hardware: x86 (IA32) Linux (All)
: medium normal
Assignee: Christoph Bumiller
QA Contact:
URL:
Whiteboard:
Keywords:
: 42835 (view as bug list)
Depends on:
Blocks:
 
Reported: 2011-11-11 14:16 UTC by Vinson Lee
Modified: 2011-11-16 15:01 UTC (History)
3 users (show)

See Also:
i915 platform:
i915 features:


Attachments
draw-instanced.png (971 bytes, image/png)
2011-11-11 14:16 UTC, Vinson Lee
Details

Description Vinson Lee 2011-11-11 14:16:10 UTC
Created attachment 53422 [details]
draw-instanced.png

mesa: bf8ad170c5af58fe9f49b3ce0f92c4eda9e5d845 (master)

$ ./bin/draw-instanced
Probe at (159,341)
  Expected: 0.000000 1.000000 0.000000 1.000000
  Observed: 0.000000 0.000000 0.000000 0.000000
draw-instanced: instance 1 failed to draw correctly
Comment 1 Vinson Lee 2011-11-11 14:38:11 UTC
919c53e87a1f6f5322bc1f1486bb3e6b954b00d5 is the first bad commit
commit 919c53e87a1f6f5322bc1f1486bb3e6b954b00d5
Author: Eric Anholt <eric@anholt.net>
Date:   Tue Nov 8 14:49:07 2011 -0800

    mesa: Make gl_VertexID be a system value like gl_InstanceID.
    
    Reviewed-by: Ian Romanick <ian.d.romanick@intel.com>

:040000 040000 c94615f2206621e7c5c9e89b79aecc75ade27e0c 13ecaad4c946809375375a62fef590f4dfe540b8 M	src
bisect run success
Comment 2 Jose Fonseca 2011-11-14 06:38:52 UTC
*** Bug 42835 has been marked as a duplicate of this bug. ***
Comment 3 Ian Romanick 2011-11-14 10:25:45 UTC
In commit 919c53e, gl_VertexID was added to the enum before gl_InstanceID.  As a result, the location of gl_InstanceID changed.  There's probably some bit of code that makes an accidental assumption about the location of gl_InstanceID.  Either that or there could be a bitfield that is now too small.
Comment 4 Jose Fonseca 2011-11-14 22:25:27 UTC
It was due to the introductin of SYSTEM_VALUE_VERTEX_ID.

Christoph just fixed this in commit:

Commit: da1544b39ebdf9b24414dcee214a5ccf76e74a77
Author: Christoph Bumiller <e0425955@student.tuwien.ac.at>
Date:   Fri Nov 11 23:18:26 2011 +0100

st/mesa: fix system value to semantic mapping
Comment 5 Vinson Lee 2011-11-16 15:01:59 UTC
mesa: f4c03da3276bee39802236c21a0b5a31f05e2541 (master)

Verified fixed. draw-instanced passes on softpipe.


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.