Bug 4298 - X server detection is failing
Summary: X server detection is failing
Status: RESOLVED FIXED
Alias: None
Product: cairo
Classification: Unclassified
Component: xlib backend (show other bugs)
Version: 1.0.0
Hardware: x86 (IA32) Linux (All)
: high normal
Assignee: Carl Worth
QA Contact: cairo-bugs mailing list
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-08-30 01:26 UTC by Frederic Crozat
Modified: 2005-08-29 17:50 UTC (History)
0 users

See Also:
i915 platform:
i915 features:


Attachments
fix X.Org server detection (501 bytes, patch)
2005-08-30 01:29 UTC, Frederic Crozat
Details | Splinter Review

Description Frederic Crozat 2005-08-30 01:26:57 UTC
Current detection of X.org server to activate fallback in cairo-xlib-surface.c
is failing on Mandriva/Mandrake system.

Attached patch fixes the issue (we had a similar issue with older version of the
distro with XFree86 but it has been fixed already in CVS).
Comment 1 Frederic Crozat 2005-08-30 01:29:28 UTC
Created attachment 3106 [details] [review]
fix X.Org server detection
Comment 2 Owen Taylor 2005-08-30 05:23:38 UTC
What is the Mandriva server string? The patch is likely fine, but I'm 
a little worried about making the strstr() check on something that is
shorter than it needs to be.
Comment 3 Frederic Crozat 2005-08-30 05:30:56 UTC
it is "Mandrakelinux (X.Org X11 6.8.2, patch level 7.1.102mdk)" for Mandrake
Linux 2005 LE

Mandriva Linux (X.Org X11 6.9, patch level 0.cvs20050825.1mdk) for next Mandriva
Release

for older releases (XF based ) :  "Mandrake Linux (XFree86 4.3, patch level
32.2.100mdk)"



Comment 4 Owen Taylor 2005-08-30 10:50:33 UTC
2005-08-30  Owen Taylor  <otaylor@redhat.com>

        * src/cairo-xlib-surface.c (_cairo_xlib_surface_create_internal):
        Liberalize the ServerVendor check so that we can handle
        the Mandriva vendor string. (#4298, Frederic Crozat)


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.