Created attachment 53834 [details] [review] Add libs to -pc.in files This allows the GABBLE_LIBS variable to be picked up correctly by projects that depend on Tp-Gabble
This is wrong in most cases. Normally, telepathy-gabble is an executable, its plugins have unresolved symbols, and it's actively harmful to link against the libtool convenience library (you'd have an entire duplicate copy of Gabble in the plugin!) Because you're building Gabble on Android as some sort of library, things are a bit weird for you. If possible, I think the right answer is to just leave the plugin with unresolved symbols - when it gets dlopen()'d, the right thing should happen, because ELF binaries are a flat global namespace. (Or does Android not use ELF?) If you really need the insides of Gabble to be a library, the right way to do this is to make it (or at least the parts of it needed by plugins) a proper shared library (probably with -release versioning to reflect that it breaks ABI frequently) under all circumstances, and link both Gabble-the-program and the plugins against this library. Mission Control does this somewhat right.
On Android it is built as a library. Using ELF works just fine, and that's how we were doing it so far. Actually, I've only come up with this change because I was asked not to hardcode the -ltelepathy-gabble when building yts-plugins (which builds a gabble plugin, thus needing the tp-gabble lib) I'm fine with keeping stuff as it was.
I'll just mark this one and the salut-related patch as INVALID, since this is out of the intended behaviour.
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.