I set CHAN_BITS to 16 in config.h. Then using MSVC6 I compiled the mesa
project. On compilation there were 11 warnings of which 9 related to the
summary above. I will detail the first one - the next 3 are similar.
On line 180 of file texcompress_fxt1.c there is a function call to
fxt1_decode_1. The last arguments, texel, is a GLchan *, which due to my
setting of CHAN_BITS, is typedef'd to unsigned short *. However, in the
function declaration on line 49 and definition on line 1638 of the same file
the final argument rgba is defined as GLubyte *. These types are therefore
On line 1367 of the same file the final argument newSource, which is defined as
GLubyte * on line 1357, is passed to the function _mesa_upscale_teximage2d.
However this parameter is (correctly?) defined as GLchan * in the declaration
and definition of the function in texstore.h/texstore.c.
Similarly in the file texcompress_s3tc.c line 175 the fourth argument pixels is
defined as GLchan *. However in the function typedef on line 72 this parameter
is declared as GLubyte *. The remaining three instances are similar.
I've fixed this in CVS. Thanks.
(In reply to comment #1)
> I've fixed this in CVS. Thanks.
In file texcompress_fxt1.c line 1663 you have redefined the local variables
r,g,b and a (see line 1609). Presumably this second definition is not required
as they will go out of scope at the end of the block (line 1672) and the values
from the original declaration will be transferred. Roy
Thanks for catching that. Fixed now.
Mass version move, cvs -> git