Bug 43441 - rendered line is too thin
Summary: rendered line is too thin
Status: RESOLVED FIXED
Alias: None
Product: poppler
Classification: Unclassified
Component: cairo backend (show other bugs)
Version: unspecified
Hardware: All Linux (All)
: medium normal
Assignee: poppler-bugs
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-12-01 17:06 UTC by wrobell
Modified: 2012-01-20 15:15 UTC (History)
0 users

See Also:
i915 platform:
i915 features:

Attachments
the pdf file causing problem (13.91 KB, application/pdf)
2011-12-01 17:06 UTC, wrobell 		Details
the screenshot (26.64 KB, image/png)
2011-12-01 17:07 UTC, wrobell 		Details
patch to fix (915 bytes, patch)
2012-01-20 02:25 UTC, Adrian Johnson 		Details | Splinter Review
View All

Description wrobell 2011-12-01 17:06:51 UTC 
Created attachment 54044 [details]
the pdf file causing problem

poppler 0.18.1, evince 3.2.1 and pdf renders improperly one of the lines. the pdf causing problem and appropriate screenshot are attached.

checked with poppler 0.16 and evince 3.0 - the file is rendered ok.
Comment 1 wrobell 2011-12-01 17:07:46 UTC 
Created attachment 54045 [details]
the screenshot
Comment 2 Albert Astals Cid 2011-12-03 03:34:04 UTC 
Not major
Comment 3 Albert Astals Cid 2011-12-03 03:35:48 UTC 
Works with splash, moving to cairo backend specific
Comment 4 wrobell 2011-12-03 06:19:58 UTC 
also checked with xpdf, which renderes the file properly
Comment 5 Adrian Johnson 2012-01-20 02:25:53 UTC 
Created attachment 55824 [details] [review]
patch to fix

The thin line has a [-1 0 0 -1] transform which triggered a bug in the code to check for lines widths less than 1 pixel. As a result the line width was set to 1 even though the width was actually 2.
Comment 6 Carlos Garcia Campos 2012-01-20 06:31:23 UTC 
Comment on attachment 55824 [details] [review]
patch to fix

Review of attachment 55824 [details] [review]:
-----------------------------------------------------------------

Perfect! Thanks, please push it to both branches.
Comment 7 Adrian Johnson 2012-01-20 15:15:44 UTC 
Pushed.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.